Bug 173940

Summary:

Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html

Product:

WebKit

Reporter:

John Wilander <wilander>

Component:

WebKit2

Assignee:

John Wilander <wilander>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, cdumez, commit-queue, dbates, japhet, rniwa, webkit-bug-importer, wilander

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=173499

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Patch for landing	none

Description John Wilander 2017-06-28 14:52:02 PDT

The regular resource load statistics telemetry handler fires, which triggers early TestRunner callbacks and test failures. We should turn off regular telemetry in layout tests.

Comment 1 John Wilander 2017-06-28 14:52:25 PDT

rdar://problem/33018125

Comment 2 John Wilander 2017-06-28 16:25:24 PDT

Created attachment 314065 [details]
Patch

Comment 3 Build Bot 2017-06-28 17:31:02 PDT

Comment on attachment 314065 [details]
Patch

Attachment 314065 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4016614

New failing tests:
media/video-no-audio.html

Comment 4 Build Bot 2017-06-28 17:31:04 PDT

Created attachment 314073 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

Comment 5 John Wilander 2017-06-29 11:50:04 PDT

Comment on attachment 314065 [details]
Patch

Had a chat with Jer Noble and the test failure is unrelated according to him.

Comment 6 Brent Fulgham 2017-06-29 13:47:34 PDT

Comment on attachment 314065 [details]
Patch

r=me

Comment 7 WebKit Commit Bot 2017-06-29 14:31:41 PDT

Comment on attachment 314065 [details]
Patch

Rejecting attachment 314065 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 314065, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
csManager.cpp
patching file Source/WebKit2/UIProcess/API/C/WKResourceLoadStatisticsManager.h
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/WebKitTestRunner/TestController.cpp
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/wk2/TestExpectations

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brent Fulgham']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/4021744

Comment 8 John Wilander 2017-06-29 15:07:53 PDT

Created attachment 314176 [details]
Patch for landing

Comment 9 WebKit Commit Bot 2017-06-29 15:22:38 PDT

Comment on attachment 314176 [details]
Patch for landing

Clearing flags on attachment: 314176

Committed r218965: <http://trac.webkit.org/changeset/218965>

Comment 10 WebKit Commit Bot 2017-06-29 15:22:40 PDT

All reviewed patches have been landed.  Closing bug.

Comment 11 John Wilander 2017-06-30 08:10:00 PDT

Committed r218995: <http://trac.webkit.org/changeset/218995>

Comment 12 John Wilander 2017-06-30 08:11:48 PDT

Last commit updated expectations with failure again. Haven't looked into why it fails now. Tested 500 iterations on my machine with no failure.