Layout Test storage/websql/database-lock-after-reload.html is a flaky failure.

• Component: New Bugs
• Status: NEW ---

[Matt Lewis]

Created attachment 314034 [details]
Crash Log, El Cap WK2

storage/websql/database-lock-after-reload.html is an intermittent flaky failure.

I've seen the test fail a few times on macOS Debug tests, mostly on Sierra, and recently saw it fail on Sierra WK1 Release. The flakiness dashboard shows these flaky failures happening for a long time, so this is not a recent regression.
Occasionally the test will crash with an assertion failure.

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Fwebsql%2Fdatabase-lock-after-reload.html

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r218872%20(1779)/results.html

diff:
--- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/storage/websql/database-lock-after-reload-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/storage/websql/database-lock-after-reload-actual.txt
@@ -1,3 +1,4 @@
+Adding a table
 Inserting some data
-Test part 2 Complete
+Test part 1 Complete
 

Crash:
0   com.apple.JavaScriptCore      	0x000000011a911f97 WTFCrash + 39 (Assertions.cpp:293)
1   com.apple.WebCore             	0x000000010d998928 WebCore::DatabaseTracker::maximumSize(WebCore::Database&) + 200 (DatabaseTracker.cpp:275)
2   com.apple.WebCore             	0x000000010d976055 WebCore::Database::maximumSize() + 37 (Database.cpp:779)
3   com.apple.WebCore             	0x000000010fb519c0 WebCore::SQLTransaction::openTransactionAndPreflight() + 480 (SQLTransaction.cpp:234)
4   com.apple.WebCore             	0x000000010fb584e9 WebCore::SQLTransactionBackend::openTransactionAndPreflight() + 25 (SQLTransactionBackend.cpp:486)
5   com.apple.WebCore             	0x000000010fb5414f WebCore::SQLTransactionStateMachine<WebCore::SQLTransactionBackend>::runStateMachine() + 367 (SQLTransactionStateMachine.h:107)
6   com.apple.WebCore             	0x000000010fb507f7 WebCore::SQLTransaction::performNextStep() + 55 (SQLTransaction.cpp:109)
7   com.apple.WebCore             	0x000000010d98e77d WebCore::DatabaseTransactionTask::doPerformTask() + 45 (DatabaseTask.cpp:161)
8   com.apple.WebCore             	0x000000010d98e35e WebCore::DatabaseTask::performTask() + 142 (DatabaseTask.cpp:80)
9   com.apple.WebCore             	0x000000010d98f1fb WebCore::DatabaseThread::databaseThread() + 299 (DatabaseThread.cpp:107)
10  com.apple.WebCore             	0x000000010d98f05d WebCore::DatabaseThread::databaseThreadStart(void*) + 29 (DatabaseThread.cpp:94)
11  com.apple.JavaScriptCore      	0x000000011a999ea9 WTF::Thread::create(void (*)(void*), void*, char const*)::$_0::operator()() const + 25 (Threading.cpp:118)
12  com.apple.JavaScriptCore      	0x000000011a999e5c WTF::Function<void ()>::CallableWrapper<WTF::Thread::create(void (*)(void*), void*, char const*)::$_0>::call() + 28 (Function.h:102)
13  com.apple.JavaScriptCore      	0x000000011a949353 WTF::Function<void ()>::operator()() const + 99 (Function.h:56)
14  com.apple.JavaScriptCore      	0x000000011a9993e5 WTF::threadEntryPoint(void*) + 149 (Threading.cpp:101)
15  com.apple.JavaScriptCore      	0x000000011a99a8c6 WTF::wtfThreadEntryPoint(void*) + 406 (ThreadingPthreads.cpp:209)
16  libsystem_pthread.dylib       	0x00007fff9659999d _pthread_body + 131
17  libsystem_pthread.dylib       	0x00007fff9659991a _pthread_start + 168
18  libsystem_pthread.dylib       	0x00007fff96597351 thread_start + 13

[Radar WebKit Bug Importer]

<rdar://problem/33122048>

[Ryan Haddad]

Marked test as flaky in https://trac.webkit.org/r227187.