Summary: | [PAL] Move KillRing into PAL | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||||||
Component: | Platform | Assignee: | Don Olmstead <don.olmstead> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bfulgham, buildbot, commit-queue, mmaxfield | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Don Olmstead
2017-06-27 19:34:37 PDT
Created attachment 314045 [details]
WIP Patch
Changes for non-Apple ports
Comment on attachment 314045 [details] WIP Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314045&action=review > Source/WebCore/PAL/pal/text/none/KillRingNone.cppSource/WebCore/platform/KillRingNone.cpp:27 > #include "KillRing.h" This file should go next to KillRing.h, not in a "none" folder. Created attachment 314068 [details]
Xcode parts
Attachment 314068 [details] did not pass style-queue:
ERROR: Source/WebCore/PAL/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 2 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 314680 [details]
Patch
Attachment 314680 [details] did not pass style-queue:
ERROR: Source/WebCore/PAL/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
ERROR: Source/WebCore/PAL/pal/PlatformMac.cmake:6: Alphabetical sorting problem. "system/mac/KillRingMac.mm" should be before "system/mac/SoundMac.mm". [list/order] [5]
Total errors found: 2 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 314682 [details]
Patch
Created attachment 314686 [details]
Patch
Comment on attachment 314686 [details] Patch Clearing flags on attachment: 314686 Committed r219213: <http://trac.webkit.org/changeset/219213> All reviewed patches have been landed. Closing bug. |