Bug 173875 – [Xcode] Add an experimental setting to build with ccache

• Component: New Bugs
• Status: RESOLVED FIXED

[Andy Estes]

[Xcode] Add an experimental setting to build with ccache

[Andy Estes]

Created attachment 313915 [details]
Patch

[Build Bot]

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

> CC_NO = $(inherited);

This is equivalent to writing

CC_NO = $(CC_NO);

which, unless CC_NO is defined at another level, is equivalent to

CC_NO = ;

which, unless CC_NO is defined at another level, is equivalent to omitting the definition.

[Andy Estes]

(In reply to mitz from comment #3)
> > CC_NO = $(inherited);
> 
> This is equivalent to writing
> 
> CC_NO = $(CC_NO);
> 
> which, unless CC_NO is defined at another level, is equivalent to
> 
> CC_NO = ;
> 
> which, unless CC_NO is defined at another level, is equivalent to omitting
> the definition.

Will omit. Thanks!

(In reply to Andy Estes from comment #4)
> (In reply to mitz from comment #3)
> > > CC_NO = $(inherited);
> > 
> > This is equivalent to writing
> > 
> > CC_NO = $(CC_NO);
> > 
> > which, unless CC_NO is defined at another level, is equivalent to
> > 
> > CC_NO = ;
> > 
> > which, unless CC_NO is defined at another level, is equivalent to omitting
> > the definition.
> 
> Will omit. Thanks!

That might still make a difference, if CC does have some value from another level, it will no always be reset to empty. I think that if you write

CC_NO = $(CC);

then when Xcode encounters the cycle at the project level (where DebugRelease.xcconfig is used) it will just ignore the setting at that level and let whatever is defined at a higher level go through.

[Andy Estes]

Created attachment 314033 [details]
Patch

Comment on attachment 314033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314033&action=review

> Tools/ccache/ccache-clang:37
> +CCACHE_SLOPPINESS="pch_defines,time_macros" ccache $(xcrun -f -sdk "$sdk" "${_XCRUN_TOOL:-clang}") "$@"

Isn’t SDKROOT already set in the environment when this script is invoked by Xcode?

[Andy Estes]

(In reply to mitz from comment #7)
> Comment on attachment 314033 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314033&action=review
> 
> > Tools/ccache/ccache-clang:37
> > +CCACHE_SLOPPINESS="pch_defines,time_macros" ccache $(xcrun -f -sdk "$sdk" "${_XCRUN_TOOL:-clang}") "$@"
> 
> Isn’t SDKROOT already set in the environment when this script is invoked by
> Xcode?

It is for CompileC commands, but not for Ld commands.

[Andy Estes]

(In reply to Andy Estes from comment #8)
> It is for CompileC commands

That's actually not even true in most cases (and I'm not sure I understand what's happening in the cases where it is). Xcode doesn't seem to configure the environment for compiler commands in the same way it would for a Run Script build phase.

[WebKit Commit Bot]

Comment on attachment 314033 [details]
Patch

Clearing flags on attachment: 314033

Committed r219082: <http://trac.webkit.org/changeset/219082>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.