Summary: | Inner elements inside a button are clipped as if the button has overflow: hidden | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Roman Komarov <kizmarh> | ||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | 7raivis, ahmad.saleem792, akeerthi, karlcow, simon.fraser, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | BrowserCompat, InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=236991 https://bugs.webkit.org/show_bug.cgi?id=26804 |
||||||
Attachments: |
|
Description
Roman Komarov
2017-06-27 05:41:33 PDT
We seem to set up a clip when painting the button. This is happening also on http://nydailynews.com (see the feedback button) This creates a webcompat issue with Firefox and Chrome. Both let the image overflow. Similar test case with an image. ``` data:text/html,<button style="width:20px;"><img style="background-color:red;width=50px;height:50px;" src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7"></button> ``` Simon is it related to this? https://searchfox.org/wubkat/rev/f3f693605e2361d756076e47b231222c5223705b/Source/WebCore/rendering/RenderButton.cpp#140-144 By any chance, is this following Blink commit: https://src.chromium.org/viewvc/blink?view=revision&revision=193213 https://github.com/WebKit/WebKit/blob/388a2cb6b11b3c27af168a286fc4c6f16baeb505/Source/WebCore/rendering/RenderButton.cpp#L154 https://github.com/WebKit/WebKit/blob/0d7afc5a45c140c44497a81e92416f01306be877/Source/WebCore/rendering/RenderButton.h#L49 Committed 257439@main (7db4da203517): <https://commits.webkit.org/257439@main> Reviewed commits have been landed. Closing PR #7062 and removing active labels. |