Bug 173766

Summary:

Remove excessive headers from WebCore/{bindings,css,dom}

Product:

WebKit

Reporter:

Konstantin Tokarev <annulen>

Component:

WebCore Misc.

Assignee:

Konstantin Tokarev <annulen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, cdumez, commit-queue, darin, mcatanzaro, simon.fraser, thorton

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Konstantin Tokarev

Reported 2017-06-23 05:33:31 PDT

Remove excessive headers from WebCore/{bindings,css,dom}

Attachments
Patch (22.19 KB, patch) 2017-06-23 05:35 PDT, Konstantin Tokarev	no flags	Details Formatted Diff Diff
Patch (21.30 KB, patch) 2017-06-23 05:44 PDT, Konstantin Tokarev	no flags	Details Formatted Diff Diff
Patch (21.73 KB, patch) 2017-06-23 06:26 PDT, Konstantin Tokarev	no flags	Details Formatted Diff Diff
Patch (22.33 KB, patch) 2017-06-23 06:42 PDT, Konstantin Tokarev	no flags	Details Formatted Diff Diff
Patch (23.38 KB, patch) 2017-06-23 07:08 PDT, Konstantin Tokarev	no flags	Details Formatted Diff Diff
Patch (23.38 KB, patch) 2017-06-23 08:20 PDT, Konstantin Tokarev	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Konstantin Tokarev

Comment 1 2017-06-23 05:35:33 PDT

Created attachment 313711 [details] Patch

Build Bot

Comment 2 2017-06-23 05:38:21 PDT

Comment on attachment 313711 [details] Patch Attachment 313711 [details] did not pass bindings-ews (mac): Output: http://webkit-queues.webkit.org/results/3983611 New failing tests: (JS) JSTestDOMJIT.h (JS) JSTestNode.h

Konstantin Tokarev

Comment 3 2017-06-23 05:44:36 PDT

Created attachment 313712 [details] Patch

Konstantin Tokarev

Comment 4 2017-06-23 06:26:25 PDT

Created attachment 313714 [details] Patch

Build Bot

Comment 5 2017-06-23 06:27:58 PDT

Attachment 313714 [details] did not pass style-queue: ERROR: Source/WebCore/ForwardingHeaders/runtime/ThrowScope.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

Konstantin Tokarev

Comment 6 2017-06-23 06:42:36 PDT

Created attachment 313715 [details] Patch

Build Bot

Comment 7 2017-06-23 06:45:09 PDT

Attachment 313715 [details] did not pass style-queue: ERROR: Source/WebCore/ForwardingHeaders/runtime/ThrowScope.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Konstantin Tokarev

Comment 8 2017-06-23 07:08:49 PDT

Created attachment 313716 [details] Patch

Build Bot

Comment 9 2017-06-23 07:10:12 PDT

Attachment 313716 [details] did not pass style-queue: ERROR: Source/WebCore/ForwardingHeaders/runtime/ThrowScope.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

Konstantin Tokarev

Comment 10 2017-06-23 08:20:02 PDT

Created attachment 313719 [details] Patch

Build Bot

Comment 11 2017-06-23 08:22:45 PDT

Attachment 313719 [details] did not pass style-queue: ERROR: Source/WebCore/ForwardingHeaders/runtime/ThrowScope.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 12 2017-06-23 12:07:36 PDT

Comment on attachment 313719 [details] Patch Clearing flags on attachment: 313719 Committed r218755: <http://trac.webkit.org/changeset/218755>

WebKit Commit Bot

Comment 13 2017-06-23 12:07:38 PDT

All reviewed patches have been landed. Closing bug.

Michael Catanzaro

Comment 14 2017-06-23 15:26:36 PDT

Thanks! Let nobody underestimate the value of these patches. What tool are you using to find these?

Michael Catanzaro

Comment 15 2017-06-23 15:29:28 PDT

Oh, I see you've already answered that in bug #173769.

Note You need to log in before you can comment on or make changes to this bug.