Bug 173758

Summary:

[WPE] Enable PUBLIC_SUFFIX_LIST

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WPE WebKit

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, zan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	zan: review+

Description Carlos Garcia Campos 2017-06-23 01:04:06 PDT

WebsiteDataStore needs it when fetching data. This is why TestWebsiteData and TestCookieManager tests fail.

TEST: bin/TestWebKitAPI/WPE/TestCookieManager... (pid=20386)
  /wpe/WebKitCookieManager/accept-policy:                              WARNING: trying to load platform resource 'missingImage'
**
ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:190:void testCookieManagerAcceptPolicy(CookieManagerTest*, gconstpointer): assertion failed (g_strv_length(domains) == 1): (0 == 1)
FAIL
GTester: last random seed: R02Sd484e6f0cf64635e0b6d2ee2b7ea8b70
(pid=20423)
  /wpe/WebKitCookieManager/delete-cookies:                             WARNING: trying to load platform resource 'missingImage'
**
ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:219:void testCookieManagerDeleteCookies(CookieManagerTest*, gconstpointer): assertion failed (g_strv_length(test->getDomains()) == 2): (1 == 2)
FAIL
GTester: last random seed: R02Sc31131ac671e283f4cfa4c361d39492b
(pid=20460)
  /wpe/WebKitCookieManager/cookies-changed:                            WARNING: trying to load platform resource 'missingImage'
OK
  /wpe/WebKitCookieManager/persistent-storage:                         WARNING: trying to load platform resource 'missingImage'
**
ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:270:void testCookieManagerPersistentStorage(CookieManagerTest*, gconstpointer): assertion failed (g_strv_length(domains) == 2): (1 == 2)
FAIL
GTester: last random seed: R02S62862d7bc480f67dc4886c500e32a989
(pid=20535)
  /wpe/WebKitCookieManager/ephemeral:                                  WARNING: trying to load platform resource 'missingImage'
**
ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:347:testCookieManagerEphemeral(CookieManagerTest*, gconstpointer)::<lambda(GObject*, GAsyncResult*, gpointer)>: assertion failed (g_strv_length(domains.get()) == 1): (0 == 1)
FAIL
GTester: last random seed: R02S35b56481b084abc696cbed468bdb9404
(pid=20582)
FAIL: bin/TestWebKitAPI/WPE/TestCookieManager

TEST: bin/TestWebKitAPI/WPE/TestWebsiteData... (pid=23404)
  /wpe/WebKitWebsiteData/configuration:                                OK
  /wpe/WebKitWebsiteData/ephemeral:                                    **
ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:250:testWebsiteDataEphemeral(WebViewTest*, gconstpointer)::<lambda(GObject*, GAsyncResult*, gpointer)>: assertion failed: (dataList)
FAIL
GTester: last random seed: R02S206677e33614131fbe9b95bb614ebc9f
(pid=23508)
  /wpe/WebKitWebsiteData/cache:                                        **
ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:278:void testWebsiteDataCache(WebsiteDataTest*, gconstpointer): assertion failed: (dataList)
FAIL
GTester: last random seed: R02Sa73b6a62b24fcbf4ffb2ee1aab25fc6a
(pid=23545)
  /wpe/WebKitWebsiteData/storage:                                      **
ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:365:void testWebsiteDataStorage(WebsiteDataTest*, gconstpointer): assertion failed: (dataList)
FAIL
GTester: last random seed: R02Sddd3bffade1804921dcd38513312e6ca
(pid=23582)
  /wpe/WebKitWebsiteData/databases:                                    **
ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:422:void testWebsiteDataDatabases(WebsiteDataTest*, gconstpointer): assertion failed: (dataList)
FAIL
GTester: last random seed: R02Sdfce6de4aaa1dc1f908b0c694a1aa8a7
(pid=23628)
  /wpe/WebKitWebsiteData/appcache:                                     **
ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:467:void testWebsiteDataAppcache(WebsiteDataTest*, gconstpointer): assertion failed: (dataList)
FAIL
GTester: last random seed: R02S31558f2bb1aa181cad752ca6e7753474
(pid=23665)
  /wpe/WebKitWebsiteData/cookies:                                      **
ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:499:void testWebsiteDataCookies(WebsiteDataTest*, gconstpointer): assertion failed: (dataList)
FAIL
GTester: last random seed: R02S2e02d306ebf8c661e2d034f7390605ba
(pid=23701)
FAIL: bin/TestWebKitAPI/WPE/TestWebsiteData

Comment 1 Carlos Garcia Campos 2017-06-23 01:09:36 PDT

Created attachment 313697 [details]
Patch

Comment 2 Carlos Garcia Campos 2017-06-23 04:08:21 PDT

Committed r218739: <http://trac.webkit.org/changeset/218739>