Summary: | REGRESSION(r217695): Offscreen/overflowed items not being rendered while translating in-frame | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bfulgham, buildbot, commit-queue, kling, simon.fraser, zalan | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=203613 | ||||||||||||||
Attachments: |
|
Description
Antti Koivisto
2017-06-22 13:45:27 PDT
Created attachment 313661 [details]
patch
Created attachment 313662 [details]
patch
Comment on attachment 313662 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=313662&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1399 > + auto bounds = FloatRect(m_boundsOrigin, size()); > + if (auto extent = animationExtent()) { Did you verify that bounds and extent are in the same coordinate space? > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2303 > + || commitState.ancestorWithTransformAnimationIntersectsCoverageRect // FIXME: Compute backing exactly for descendants of animating layers . No space before period. > LayoutTests/compositing/backing/transform-transition-from-outside-view.html:33 > + .dot { > + position: absolute; > + top: 0; > + left: 0; > + height: 4px; > + width: 4px; > + background-color: silver; > + } You're not using dots. > LayoutTests/compositing/backing/transform-transition-from-outside-view.html:36 > + -webkit-transform: translateX(0px); Transforms are unprefixed. Comment on attachment 313662 [details] patch Attachment 313662 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3980253 New failing tests: compositing/backing/transform-transition-from-outside-view.html Created attachment 313668 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
> Did you verify that bounds and extent are in the same coordinate space?
Both seem to be in the coordinate space used by RenderLayer::calculateLayerBounds so I think this is correct.
Created attachment 313682 [details]
patch
Created attachment 313687 [details]
patch
Comment on attachment 313687 [details] patch Clearing flags on attachment: 313687 Committed r218735: <http://trac.webkit.org/changeset/218735> All reviewed patches have been landed. Closing bug. |