Bug 17373

Summary: Language code in User-Agent header doesn't support 3- or 4-letter language codes
Product: WebKit Reporter: Nicholas Shanks <nickshanks>
Component: Page LoadingAssignee: Nicholas Shanks <nickshanks>
Status: ASSIGNED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch, v1.0 darin: review-

Nicholas Shanks
Reported 2008-02-15 04:39:43 PST
ISO 639-2 (alpha 3) language codes, and the reserved four-letter locale initial position should be supported for underscore to hyphen conversion.
Attachments
Proposed patch, v1.0 (1.39 KB, patch)
2008-02-15 04:40 PST, Nicholas Shanks 		darin: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nicholas Shanks
Comment 1 2008-02-15 04:40:34 PST
Created attachment 19136 [details] Proposed patch, v1.0
Darin Adler
Comment 2 2008-02-20 09:24:14 PST
Comment on attachment 19136 [details] Proposed patch, v1.0 Seems OK. What are some actual language codes we can test this with. Do we know what this does to website compatibility? No change log. No regression tests. Need to find a way to regression-test this. Formatting does not match style guide: single line if statements should not have braces. Fix seems fine with some minor problems. Benefit also seems small unless there's some actual language code that's going to come up in practice, so setting to review- to get the minor problems fixed.
Note You need to log in before you can comment on or make changes to this bug.