Bug 17372 – REGRESSION (r30243): Windows ASSERTS on startup

• Component: Page Loading
• Status: RESOLVED FIXED

[Matt Lilek]

Trying to load anything on Windows (even an "empty" home page) after this rev fails the ASSERT on MainResourceLoader.cpp:147

>	WebKit.dll!WebCore::MainResourceLoader::willSendRequest(WebCore::ResourceRequest & newRequest={...}, const WebCore::ResourceResponse & redirectResponse={...})  Line 147 + 0x2b bytes	C++
 	WebKit.dll!WebCore::MainResourceLoader::loadNow(WebCore::ResourceRequest & r={...})  Line 365 + 0x1f bytes	C++
 	WebKit.dll!WebCore::MainResourceLoader::load(const WebCore::ResourceRequest & r={...}, const WebCore::SubstituteData & substituteData={...})  Line 402 + 0xf bytes	C++
 	WebKit.dll!WebCore::DocumentLoader::startLoadingMainResource(unsigned long identifier=1)  Line 691 + 0x31 bytes	C++
 	WebKit.dll!WebCore::FrameLoader::continueLoadAfterWillSubmitForm(WebCore::PolicyAction __formal=PolicyUse)  Line 3023 + 0x16 bytes	C++
 	WebKit.dll!WebCore::FrameLoader::continueLoadAfterNavigationPolicy(const WebCore::ResourceRequest & request={...}, WTF::PassRefPtr<WebCore::FormState> formState={...}, bool shouldContinue=true)  Line 3623	C++
 	WebKit.dll!WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy(void * argument=0x033e6820, const WebCore::ResourceRequest & request={...}, WTF::PassRefPtr<WebCore::FormState> formState={...}, bool shouldContinue=true)  Line 3570	C++
 	WebKit.dll!WebCore::FrameLoader::checkNavigationPolicy(const WebCore::ResourceRequest & request={...}, WebCore::DocumentLoader * loader=0x032dfc80, WTF::PassRefPtr<WebCore::FormState> formState={...}, void (void *, const WebCore::ResourceRequest &, WTF::PassRefPtr<WebCore::FormState>, bool)* function=0x00a4b040, void * argument=0x033e6820)  Line 3511 + 0x17 bytes	C++
 	WebKit.dll!WebCore::FrameLoader::load(WebCore::DocumentLoader * loader=0x032dfc80, WebCore::FrameLoadType type=FrameLoadTypeStandard, WTF::PassRefPtr<WebCore::FormState> formState={...})  Line 2135	C++
 	WebKit.dll!WebCore::FrameLoader::load(WebCore::DocumentLoader * newDocumentLoader=0x032dfc80)  Line 2114	C++
 	WebKit.dll!WebCore::FrameLoader::load(const WebCore::ResourceRequest & request={...}, const WebCore::SubstituteData & substituteData={...})  Line 2060 + 0x3d bytes	C++
 	WebKit.dll!WebFrame::loadData(WTF::PassRefPtr<WebCore::SharedBuffer> data={...}, wchar_t * mimeType=0x00000000, wchar_t * textEncodingName=0x0016e094, wchar_t * baseURL=0x00000000, wchar_t * failingURL=0x00000000)  Line 642	C++
 	WebKit.dll!WebFrame::loadHTMLString(wchar_t * string=0x00184974, wchar_t * baseURL=0x00000000, wchar_t * unreachableURL=0x00000000)  Line 674	C++
 	WebKit.dll!WebFrame::loadHTMLString(wchar_t * string=0x00184974, wchar_t * baseURL=0x00000000)  Line 681	C++
 	Safari.exe!00501812() 	
 	[Frames below may be incorrect and/or missing, no symbols loaded for Safari.exe]	
 	Safari.exe!00501026() 	
 	Safari.exe!004ffd55() 	
 	Safari.exe!0040ada8() 	
 	user32.dll!7e418734() 	
 	user32.dll!7e418816() 	
 	user32.dll!7e41b4c0() 	
 	user32.dll!7e41f104() 	
 	ntdll.dll!7c90e453() 	
 	user32.dll!7e420a9f() 	
 	user32.dll!7e420a65() 	
 	ntdll.dll!7c910202() 	
 	ntdll.dll!7c9158df() 	
 	ntdll.dll!7c915bd8() 	
 	ntdll.dll!7c915c3d() 	
 	ntdll.dll!7c915219() 	
 	ntdll.dll!7c91540b() 	
 	ntdll.dll!7c910098() 	
 	ntdll.dll!7c910021() 	
 	ntdll.dll!7c91003d() 	
 	ntdll.dll!7c9157a1() 	
 	ntdll.dll!7c91532a() 	
 	ntdll.dll!7c915722() 	
 	ntdll.dll!7c9155cd() 	
 	ntdll.dll!7c91003d() 	
 	user32.dll!7e419951() 	
 	ntdll.dll!7c910303() 	
 	ntdll.dll!7c910303() 	
 	user32.dll!7e4199e4() 	
 	user32.dll!7e419a12() 	
 	user32.dll!7e41a303() 	
 	user32.dll!7e419a12() 	
 	user32.dll!7e41a31a() 	
 	user32.dll!7e41a33b() 	
 	user32.dll!7e42812e() 	
 	ntdll.dll!7c910202() 	
 	ntdll.dll!7c910202() 	
 	ntdll.dll!7c911066() 	
 	ntdll.dll!7c9101bb() 	
 	ntdll.dll!7c910202() 	
 	ntdll.dll!7c911066() 	
 	ntdll.dll!7c9101bb() 	
 	ntdll.dll!7c910098() 	
 	ntdll.dll!7c910021() 	
 	ntdll.dll!7c91003d() 	
 	WebKit.dll!WebCore::FloatRect::height()  Line 76 + 0x19 bytes	C++
 	WebKit.dll!WebCore::FloatRect::bottom()  Line 86 + 0x2d bytes	C++
 	ntdll.dll!7c910303() 	
 	user32.dll!7e420b58() 	
 	WebKit.dll!WTF::fastFree(void * p=0x00000002)  Line 189 + 0x8 bytes	C++
 	WebKit.dll!operator delete(void * p=0x033f2e60)  Line 70 + 0xc bytes	C++
 	WebKit.dll!WebCore::Event::`scalar deleting destructor'()  + 0x27 bytes	C++
 	WebKit.dll!WTF::RefCounted<WebCore::Event>::deref()  Line 53 + 0x41 bytes	C++
 	00150268()

[Darin Adler]

Adam, can you help me figure this out in the morning so I don't have to roll my change out? I'm sure it's something simple -- just making an empty URL or something.

[Alexey Proskuryakov]

I have copied Mac logic for null baseURL into WebFrame::loadData, which has resolved this assertion, but this doesn't seem to be sufficient - I'm getting further failures inside Safari. Investigating whether they are related.

[Alexey Proskuryakov]

Created attachment 19135 [details]
work in progress

[Alexey Proskuryakov]

Alas, looks like this is not sufficient - non-local build of Safari also fails to start with my WebKit build.

[Adam Roben (:aroben)]

I'm going to start looking at this now.

[Adam Roben (:aroben)]

Here's the asserting line <http://trac.webkit.org/projects/webkit/browser/trunk/WebCore/loader/MainResourceLoader.cpp?rev=29511#L147>:

    ASSERT(!newRequest.isNull());

[Adam Roben (:aroben)]

Fixed in r30268 <http://trac.webkit.org/projects/webkit/changeset/30268>