Bug 173663

Summary: B3BreakCriticalEdges.cpp with /O2 causes ICE in VS2015, 2017
Product: WebKit Reporter: Vladimir Vukicevic <vladimir>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
make this file build with /Os none

Vladimir Vukicevic
Reported 2017-06-21 11:05:15 PDT
With Visual Studio 2015, 2017 (vc 14.0/14.1) building B3BreakCriticalEdges.cpp with the default /O2 (or /Ox) causes an internal compiler error: c:\proj\js\webkit\source\javascriptcore\b3\b3breakcriticaledges.cpp(62) : fatal error C1001: An internal error has occurred in the compiler. (compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 255) To work around this problem, try simplifying or changing the program near the locations listed above. Please choose the Technical Support command on the Visual C++ Help menu, or open the Technical Support help file for more information INTERNAL COMPILER ERROR in 'C:\PROGRA~2\MICROS~1\2017\PROFES~1\VC\Tools\MSVC\1410~1.250\bin\HostX86\x64\cl.exe' Please choose the Technical Support command on the Visual C++ Help menu, or open the Technical Support help file for more information "/Os" builds fine.
Attachments
make this file build with /Os (1.03 KB, patch)
2017-06-22 08:53 PDT, Vladimir Vukicevic 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vladimir Vukicevic
Comment 1 2017-06-22 08:53:35 PDT
Created attachment 313630 [details] make this file build with /Os This fixes it for me, though it does rely on cmake always appending source options. I think that's safe, though.
Note You need to log in before you can comment on or make changes to this bug.