Bug 173650

Summary: [GTK] Fix the condition to enable/disable GSTREAMER_GL
Product: WebKit Reporter: Miguel Gomez <magomez>
Component: WebKitGTKAssignee: Miguel Gomez <magomez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Miguel Gomez
Reported 2017-06-21 06:47:13 PDT
Currently the build checks whether gstreamer-gl version is higher than 1.8.0 and fails if that doesn't happen. That's not desirable. We want to disable GSTREAMER_GL if the gstreamer version is < 1.10, but not fail. Then, if the version is bigger than 1.10, we should fail if the gstreamer-gl package is not available.
Attachments
Patch (2.67 KB, patch)
2017-06-21 06:55 PDT, Miguel Gomez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Miguel Gomez
Comment 1 2017-06-21 06:55:53 PDT
Created attachment 313515 [details] Patch
WebKit Commit Bot
Comment 2 2017-06-21 08:50:51 PDT
Comment on attachment 313515 [details] Patch Clearing flags on attachment: 313515 Committed r218631: <http://trac.webkit.org/changeset/218631>
WebKit Commit Bot
Comment 3 2017-06-21 08:50:53 PDT
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 4 2017-06-23 17:20:29 PDT
Miguel tested, Michael approved! (I know nobody is going to get this joke... it's a terrible and not at all funny pun on some old commercials for an American breakfast cereal, Kix. But I really wanted to type it.)
Note You need to log in before you can comment on or make changes to this bug.