Bug 173648 – [GCrypt] Implement CryptoKeyEC PKCS#8 exports

• Component: New Bugs
• Status: RESOLVED FIXED

[Zan Dobersek]

SSIA.

[Zan Dobersek]

Created attachment 313514 [details]
WIP patch

[Build Bot]

Attachment 313514 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Zan Dobersek]

Created attachment 313826 [details]
WIP patch

[Build Bot]

Attachment 313826 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Zan Dobersek]

Created attachment 314026 [details]
Patch

[Zan Dobersek]

(In reply to Zan Dobersek from comment #5)
> Created attachment 314026 [details]
> Patch

This is ready for review, but the patch still relies on libtasn1 helpers that are being added in bug #173646.

[Zan Dobersek]

Created attachment 314461 [details]
Patch

Now buildable.

[Build Bot]

Comment on attachment 314461 [details]
Patch

Attachment 314461 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4044017

New failing tests:
workers/bomb.html

[Build Bot]

Created attachment 314479 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Jiewen Tan]

Comment on attachment 314461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314461&action=review

Looks good to me. r=me. Please address the following comments before landing.

> Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:508
> +        // Construct the EC context that we'll use to retrieve private and public key data.

I believe private key should be ahead of parameters even though the end result is the same.

> Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:542
> +        // Create the `SubjectPublicKeyInfo` structure.

Shouldn't it be "PrivateKeyInfo"?

> Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:553
> +        if (!PAL::TASN1::writeElement(pkcs8, "privateKeyAlgorithm.algorithm", "1.2.840.10045.2.1", 1))

Remember to make "1.2.840.10045.2.1" as a constant in a followup patch.

[Zan Dobersek]

Comment on attachment 314461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314461&action=review

>> Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:508
>> +        // Construct the EC context that we'll use to retrieve private and public key data.
> 
> I believe private key should be ahead of parameters even though the end result is the same.

I'll switch the order for the sake of consistency with the ASN.1 definition.

>> Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:542
>> +        // Create the `SubjectPublicKeyInfo` structure.
> 
> Shouldn't it be "PrivateKeyInfo"?

Yes.

>> Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:553
>> +        if (!PAL::TASN1::writeElement(pkcs8, "privateKeyAlgorithm.algorithm", "1.2.840.10045.2.1", 1))
> 
> Remember to make "1.2.840.10045.2.1" as a constant in a followup patch.

Will do.

[Zan Dobersek]

Created attachment 315229 [details]
Patch for landing

[Zan Dobersek]

Comment on attachment 315229 [details]
Patch for landing

Clearing flags on attachment: 315229

Committed r219392: <http://trac.webkit.org/changeset/219392>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.