Bug 17362
| Summary: | discovered dead code in SVG stylesheet title handling of "&" | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> |
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | zimmermann |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Darin Adler
In Document::recalcStyleSelector I discovered some dead code that I removed:
#if ENABLE(SVG)
// FIXME: What's the point of changing the value of a local variable
// (title) that's not looked at afterward? Obviously there's no test
// case for this!
if (!n->isHTMLElement()) {
String modifiedTitle = title.domString();
title = modifiedTitle.replace('&', "&&");
}
#endif
We should figure out what this code was trying to do, and then possibly re-add the code with a test case.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Nikolas Zimmermann
In practice this never turned out to be a problem - closing this bug.