Bug 173583

Summary:

Use WTF::Function instead of std::function in more places in WebCore/

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, buildbot, commit-queue, darin, kling, koivisto, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2017-06-19 22:14:41 PDT

Use WTF::Function instead of std::function in more places in WebCore/ to reduce copying.

Attachments
Patch (77.96 KB, patch) 2017-06-19 22:17 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (78.22 KB, patch) 2017-06-19 22:33 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (78.44 KB, patch) 2017-06-19 22:35 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (78.36 KB, patch) 2017-06-19 22:47 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (79.56 KB, patch) 2017-06-20 09:11 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (80.77 KB, patch) 2017-06-20 09:31 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (80.77 KB, patch) 2017-06-20 11:02 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (80.77 KB, patch) 2017-06-20 13:09 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-06-19 22:17:55 PDT

Created attachment 313367 [details] Patch

Build Bot

Comment 2 2017-06-19 22:19:15 PDT

Attachment 313367 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:32: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:296: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:675: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.cpp:43: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:62: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:134: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/workers/Worker.cpp:62: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/Page.cpp:284: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.h:574: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/CookieStorageSoup.cpp:26: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:297: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp:60: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/Path.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/Path.h:104: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.cpp:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/Logging.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/CookieStorage.h:34: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:49: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:72: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:35: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:39: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:2092: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3378: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3453: Missing space before { [whitespace/braces] [5] Total errors found: 34 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 3 2017-06-19 22:33:47 PDT

Created attachment 313369 [details] Patch

Build Bot

Comment 4 2017-06-19 22:35:02 PDT

Attachment 313369 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:32: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:296: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:675: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.cpp:43: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:62: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:134: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/workers/Worker.cpp:62: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/Page.cpp:284: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.h:574: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/CookieStorageSoup.cpp:26: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:297: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp:60: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/Path.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/Path.h:104: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.cpp:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/Logging.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/CookieStorage.h:34: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:49: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:72: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:35: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:39: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:2092: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3378: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3453: Missing space before { [whitespace/braces] [5] Total errors found: 34 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 5 2017-06-19 22:35:33 PDT

Created attachment 313370 [details] Patch

Build Bot

Comment 6 2017-06-19 22:37:58 PDT

Attachment 313370 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:32: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:296: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:675: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.cpp:43: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:62: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:134: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/workers/Worker.cpp:62: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/Page.cpp:284: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.h:574: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/CookieStorageSoup.cpp:26: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:297: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp:60: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/Path.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/Path.h:104: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.cpp:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/Logging.cpp:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/CookieStorage.h:34: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:49: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:72: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:35: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:39: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:2092: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3378: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3453: Missing space before { [whitespace/braces] [5] Total errors found: 34 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 7 2017-06-19 22:47:35 PDT

Created attachment 313371 [details] Patch

Build Bot

Comment 8 2017-06-19 22:49:07 PDT

Attachment 313371 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:32: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:296: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:675: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.cpp:43: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:62: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:134: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/workers/Worker.cpp:62: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/Page.cpp:284: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.h:574: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/CookieStorageSoup.cpp:26: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:297: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp:60: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/Path.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/Path.h:104: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.cpp:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/Logging.cpp:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/CookieStorage.h:34: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:49: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:72: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:35: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:39: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:2092: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3378: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3453: Missing space before { [whitespace/braces] [5] Total errors found: 34 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 9 2017-06-20 09:11:12 PDT

Created attachment 313402 [details] Patch

Build Bot

Comment 10 2017-06-20 09:12:24 PDT

Attachment 313402 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:32: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:296: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:675: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.cpp:43: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:62: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:134: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/workers/Worker.cpp:62: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/Page.cpp:284: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.h:574: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/CookieStorageSoup.cpp:26: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:297: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp:60: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/Path.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/Path.h:104: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.cpp:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/Logging.cpp:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/CookieStorage.h:34: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:49: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:35: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:39: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/mac/PageMac.mm:64: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/mac/PageMac.mm:65: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:2092: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3378: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3453: Missing space before { [whitespace/braces] [5] Total errors found: 36 in 67 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 11 2017-06-20 09:31:10 PDT

Created attachment 313405 [details] Patch

Build Bot

Comment 12 2017-06-20 09:38:03 PDT

Attachment 313405 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:32: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:296: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:675: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.cpp:43: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:62: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:134: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/workers/Worker.cpp:62: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/Page.cpp:284: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.h:574: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/CookieStorageSoup.cpp:26: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:297: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp:60: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/Path.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/Path.h:104: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.cpp:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/Logging.cpp:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/CookieStorage.h:34: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:49: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:35: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:39: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/mac/PageMac.mm:64: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/mac/PageMac.mm:65: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:2092: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/rendering/SimpleLineLayout.cpp:257: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/rendering/SimpleLineLayout.cpp:258: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/rendering/SimpleLineLayout.cpp:259: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3378: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3453: Missing space before { [whitespace/braces] [5] Total errors found: 39 in 68 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 13 2017-06-20 11:02:25 PDT

Created attachment 313414 [details] Patch

Build Bot

Comment 14 2017-06-20 11:04:37 PDT

Attachment 313414 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:32: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:296: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:675: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.cpp:43: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:62: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:134: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/workers/Worker.cpp:62: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/Page.cpp:284: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.h:574: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/CookieStorageSoup.cpp:26: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:297: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp:60: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/Path.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/Path.h:104: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.cpp:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/Logging.cpp:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/CookieStorage.h:34: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:49: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:35: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:39: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/mac/PageMac.mm:64: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/mac/PageMac.mm:65: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:2092: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/rendering/SimpleLineLayout.cpp:257: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/rendering/SimpleLineLayout.cpp:258: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/rendering/SimpleLineLayout.cpp:259: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3378: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3453: Missing space before { [whitespace/braces] [5] Total errors found: 39 in 68 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 15 2017-06-20 13:09:53 PDT

Created attachment 313429 [details] Patch

Build Bot

Comment 16 2017-06-20 13:12:05 PDT

Attachment 313429 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:32: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:296: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:675: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.cpp:43: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:62: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:134: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/workers/Worker.cpp:62: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/Page.cpp:284: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/network/soup/SoupNetworkSession.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.h:574: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/soup/CookieStorageSoup.cpp:26: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/WebCoreNSURLExtras.mm:297: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp:60: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/Path.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/Path.h:104: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.cpp:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/Logging.cpp:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/CookieStorage.h:34: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:49: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:35: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:39: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/mac/CookieStorageMac.mm:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/mac/PageMac.mm:64: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/mac/PageMac.mm:65: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:2092: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/rendering/SimpleLineLayout.cpp:257: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/rendering/SimpleLineLayout.cpp:258: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/rendering/SimpleLineLayout.cpp:259: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3378: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3453: Missing space before { [whitespace/braces] [5] Total errors found: 39 in 68 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 17 2017-06-20 16:12:48 PDT

Comment on attachment 313429 [details] Patch Should do more #pragma once as you go. Annoying that we can’t just pass a C++ function to WTF::Function. Not sure I understand why.

WebKit Commit Bot

Comment 18 2017-06-20 16:42:23 PDT

Comment on attachment 313429 [details] Patch Clearing flags on attachment: 313429 Committed r218615: <http://trac.webkit.org/changeset/218615>

WebKit Commit Bot

Comment 19 2017-06-20 16:42:25 PDT

All reviewed patches have been landed. Closing bug.

Chris Dumez

Comment 20 2017-06-20 16:48:26 PDT

(In reply to Darin Adler from comment #17) > Comment on attachment 313429 [details] > Patch > > Should do more #pragma once as you go. > > Annoying that we can’t just pass a C++ function to WTF::Function. Not sure I > understand why. Right, this is annoying. I will look into making this work.

Note You need to log in before you can comment on or make changes to this bug.