Bug 173560 – Layout Test inspector/css/add-rule.html is flaky.

• Component: New Bugs
• Status: NEW

[Matt Lewis]

inspector/css/add-rule.html is a flaky timeout on macOS Debug builds according to the flakiness dashboard.

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcss%2Fadd-rule.html

Test was added in r217911 and seems to have been flaky since being added
https://trac.webkit.org/changeset/217911/webkit

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r218496%20(1938)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/1938

First timeout was on macOS El Capitan WK1:
https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/builds/1727

diff:
--- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/inspector/css/add-rule-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/inspector/css/add-rule-actual.txt
@@ -1,22 +1,2 @@
+FAIL: Timed out waiting for notifyDone to be called
 Testing that CSS.addRule works for all types of stylesheets.
-
-
-== Running test suite: CSS.addRule
--- Running test case: CSS.addRule.InNonExistingInspectorStyleSheet
-PASS: Rule selector should be "body"
-PASS: Rule range should be [0:0,0:4]
-PASS: Rule origin should be "inspector"
-
--- Running test case: CSS.addRule.InExistingInspectorStyleSheet
-PASS: Rule selector should be "div"
-PASS: Rule range should be [1:0,1:3]
-PASS: Rule origin should be "inspector"
-
--- Running test case: CSS.addRule.ExternalStyleSheet
-PASS: Rule selector should be "div"
-PASS: Rule range should be [2:0,2:3]
-PASS: Rule origin should be "regular"
-
--- Running test case: CSS.addRule.BadStyleSheetId
-PASS: No target stylesheet found
-

[Alexey Proskuryakov]

So should we roll back the change?

[Matt Lewis]

Marked test as flaky on macOS:
https://trac.webkit.org/changeset/220972/webkit