Bug 173554

Summary:

Remove excessive include directives from WebCore/css

Product:

WebKit

Reporter:

Konstantin Tokarev <annulen>

Component:

WebCore Misc.

Assignee:

Konstantin Tokarev <annulen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, darin, rniwa, sam

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Konstantin Tokarev

Reported 2017-06-19 11:06:49 PDT

Remove excessive include directives from WebCore/css

Attachments
Patch (30.88 KB, patch) 2017-06-19 11:09 PDT, Konstantin Tokarev	no flags	Details Formatted Diff Diff
Patch (30.69 KB, patch) 2017-06-19 11:28 PDT, Konstantin Tokarev	no flags	Details Formatted Diff Diff
Patch (30.30 KB, patch) 2017-06-19 11:39 PDT, Konstantin Tokarev	no flags	Details Formatted Diff Diff
Patch (29.88 KB, patch) 2017-06-19 11:51 PDT, Konstantin Tokarev	no flags	Details Formatted Diff Diff
Patch (30.00 KB, patch) 2017-06-20 03:05 PDT, Konstantin Tokarev	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Konstantin Tokarev

Comment 1 2017-06-19 11:09:10 PDT

Created attachment 313312 [details] Patch

Konstantin Tokarev

Comment 2 2017-06-19 11:28:19 PDT

Created attachment 313315 [details] Patch

Konstantin Tokarev

Comment 3 2017-06-19 11:39:59 PDT

Created attachment 313318 [details] Patch

Konstantin Tokarev

Comment 4 2017-06-19 11:51:18 PDT

Created attachment 313321 [details] Patch

Alex Christensen

Comment 5 2017-06-19 14:17:56 PDT

Comment on attachment 313321 [details] Patch Beautiful.

WebKit Commit Bot

Comment 6 2017-06-19 14:23:24 PDT

Comment on attachment 313321 [details] Patch Rejecting attachment 313321 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 313321, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: .h patching file Source/WebCore/html/BaseCheckableInputType.cpp patching file Source/WebCore/html/MediaController.cpp patching file Source/WebCore/html/track/TextTrack.cpp patching file Source/WebCore/html/track/TextTrackCue.cpp patching file Source/WebCore/html/track/VideoTrack.cpp patching file Source/WebCore/loader/TextTrackLoader.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3962302

WebKit Commit Bot

Comment 7 2017-06-19 21:36:43 PDT

Comment on attachment 313321 [details] Patch Rejecting attachment 313321 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 313321, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: .h patching file Source/WebCore/html/BaseCheckableInputType.cpp patching file Source/WebCore/html/MediaController.cpp patching file Source/WebCore/html/track/TextTrack.cpp patching file Source/WebCore/html/track/TextTrackCue.cpp patching file Source/WebCore/html/track/VideoTrack.cpp patching file Source/WebCore/loader/TextTrackLoader.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3964028

Konstantin Tokarev

Comment 8 2017-06-20 03:05:29 PDT

Created attachment 313389 [details] Patch

Konstantin Tokarev

Comment 9 2017-06-20 04:38:52 PDT

Committed r218588: <http://trac.webkit.org/changeset/218588>

Note You need to log in before you can comment on or make changes to this bug.