Bug 173551 – [Cocoa] implement URLSession:task:needNewBodyStream: delegate method

• Component: Page Loading
• Status: RESOLVED FIXED

[Darin Adler]

[Cocoa] implement URLSession:task:needNewBodyStream: delegate method

[Darin Adler]

Created attachment 313308 [details]
Patch

[Darin Adler]

rdar://problem/32250512

[Alex Christensen]

Comment on attachment 313308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313308&action=review

Thanks, Darin!  I'm going to look into getting this into landing condition.

> Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm:154
> +    // FIXME: Is this guaranteed to be correct even when redirects are involved?
> +    auto* body = networkDataTask->firstRequest().httpBody();

NSURLSessionTask has currentRequest

[Alex Christensen]

Comment on attachment 313308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313308&action=review

>> Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm:154
>> +    auto* body = networkDataTask->firstRequest().httpBody();
> 
> NSURLSessionTask has currentRequest

Ah, we do want the http body of the first request, even if redirected.  This is an HTTP POST request.

> Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm:160
> +    // FIXME: Is there a problem if some files are different in size since the original sizing?

I think if someone modifies a file as we are uploading it they're going to have a bad time anyways.

[Alex Christensen]

Created attachment 313340 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 313340 [details]
Patch

Clearing flags on attachment: 313340

Committed r218517: <http://trac.webkit.org/changeset/218517>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.