Bug 173504

Summary:

Use WTF::Function instead of std::function in WebKit2/

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, buildbot, commit-queue, darin, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2017-06-16 18:23:09 PDT

Use WTF::Function instead of std::function in NetworkProcessProxy to avoid unnecessary copying.

Attachments
Patch (8.49 KB, patch) 2017-06-16 18:23 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (181.17 KB, patch) 2017-06-16 20:55 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (181.52 KB, patch) 2017-06-16 21:02 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (182.55 KB, patch) 2017-06-16 21:17 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (182.56 KB, patch) 2017-06-16 21:44 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-06-16 18:23:50 PDT

Created attachment 313171 [details] Patch

Build Bot

Comment 2 2017-06-16 18:25:00 PDT

Attachment 313171 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:125: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:140: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:131: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:132: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:133: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 3 2017-06-16 20:55:28 PDT

Created attachment 313178 [details] Patch

Build Bot

Comment 4 2017-06-16 20:57:06 PDT

Attachment 313178 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:63: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2205: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebBackForwardList.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginStream.mm:305: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.cpp:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:105: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:112: Missing space after , [whitespace/comma] [3] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:112: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:125: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:140: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:176: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:195: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:237: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:160: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:167: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:174: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:876: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:876: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:879: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.h:201: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.h:299: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:228: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:50: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:131: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:132: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:116: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:129: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:142: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h:71: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.mm:134: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:48: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginStream.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:443: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/loader/NetscapePlugInStreamLoader.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/loader/NetscapePlugInStreamLoader.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:42: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:92: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:93: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.cpp:720: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:99: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:361: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:407: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:296: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.h:42: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIIconLoadingClient.h:42: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIIconLoadingClient.h:42: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebBackForwardList.cpp:398: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxy.h:93: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:426: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:437: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:458: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:469: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:480: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:498: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:509: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:531: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:542: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:553: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:577: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:588: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:620: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:743: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:960: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:1599: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:1624: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2349: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2822: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2833: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2844: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2856: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2868: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2880: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2892: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2918: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6288: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6299: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6310: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6321: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6365: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6585: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6717: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6747: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:433: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:461: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:477: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:505: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:506: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:507: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:511: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:512: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:513: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:514: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:516: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:517: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:519: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:520: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:522: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:524: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:535: Extra space before ( in f unction call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:596: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:597: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:598: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:599: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:610: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:612: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:671: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:781: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:782: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:783: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:784: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:791: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:792: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:794: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:796: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1046: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1093: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:59: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:294: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:295: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h:64: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h:65: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h:66: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:225: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:606: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:1520: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:108: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.mm:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:299: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:215: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:218: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:45: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:67: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Plugins/PluginView.cpp:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Plugins/PluginView.cpp:145: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Plugins/PluginView.cpp:224: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:304: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:314: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:330: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:341: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:344: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/DrawingArea.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:177: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:203: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.cpp:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.cpp:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.h:123: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 190 in 94 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 5 2017-06-16 21:02:16 PDT

Created attachment 313179 [details] Patch

Build Bot

Comment 6 2017-06-16 21:04:12 PDT

Attachment 313179 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:63: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2205: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebBackForwardList.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginStream.mm:305: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.cpp:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:105: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:112: Missing space after , [whitespace/comma] [3] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:112: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:125: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:140: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:176: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:195: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:237: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:160: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:167: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:174: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:876: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:876: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:879: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.h:201: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.h:299: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:228: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:50: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:131: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:132: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:116: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:129: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:142: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h:71: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.mm:134: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:48: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginStream.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:443: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/loader/NetscapePlugInStreamLoader.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/loader/NetscapePlugInStreamLoader.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:42: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:92: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:93: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.cpp:720: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:99: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:361: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:407: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:296: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.h:42: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIIconLoadingClient.h:42: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIIconLoadingClient.h:42: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebBackForwardList.cpp:398: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxy.h:93: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:426: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:437: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:458: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:469: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:480: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:498: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:509: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:531: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:542: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:553: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:577: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:588: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:620: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:743: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:960: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:1599: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:1624: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2349: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2822: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2833: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2844: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2856: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2868: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2880: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2892: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2918: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6288: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6299: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6310: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6321: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6365: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6585: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6717: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6747: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:433: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:461: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:477: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:505: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:506: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:507: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:511: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:512: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:513: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:514: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:516: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:517: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:519: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:520: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:522: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:524: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:535: Extra space before ( in f unction call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:596: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:597: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:598: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:599: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:610: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:612: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:671: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:781: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:782: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:783: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:784: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:791: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:792: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:794: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:796: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1046: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1093: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:59: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:294: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:295: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h:64: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h:65: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h:66: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:225: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:606: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:1520: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:108: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.mm:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:299: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:215: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:218: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:45: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:67: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Plugins/PluginView.cpp:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Plugins/PluginView.cpp:145: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Plugins/PluginView.cpp:224: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreX11.cpp:104: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreX11.cpp:97: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:304: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:314: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:330: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:341: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:344: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/DrawingArea.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:177: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:203: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.cpp:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.cpp:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.h:123: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 192 in 94 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 7 2017-06-16 21:17:54 PDT

Created attachment 313182 [details] Patch

Build Bot

Comment 8 2017-06-16 21:20:27 PDT

Attachment 313182 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:63: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2205: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebBackForwardList.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginStream.mm:305: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.cpp:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:105: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:112: Missing space after , [whitespace/comma] [3] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:112: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:125: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:140: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:176: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:195: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:237: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:160: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:167: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:174: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:876: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:876: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:879: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.h:201: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.h:299: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:228: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:50: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:131: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:132: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:116: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:129: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:142: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h:71: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.mm:134: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:48: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginStream.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:443: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/loader/NetscapePlugInStreamLoader.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/loader/NetscapePlugInStreamLoader.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:42: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:92: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:93: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.cpp:720: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:813: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:99: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:361: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:407: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:296: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.h:42: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIIconLoadingClient.h:42: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIIconLoadingClient.h:42: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebBackForwardList.cpp:398: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxy.h:93: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:426: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:437: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:458: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:469: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:480: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:498: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:509: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:531: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:542: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:553: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:577: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:588: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:620: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:743: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:960: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:1599: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:1624: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2349: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2822: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2833: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2844: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2856: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2868: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2880: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2892: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2918: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6288: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6299: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6310: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6321: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6365: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6585: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6717: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6747: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:433: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:461: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:477: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:505: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:506: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:507: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:511: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:512: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:513: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:514: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:516: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:517: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:519: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:520: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:522: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:524: Extra space bef ore ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:535: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:596: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:597: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:598: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:599: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:610: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:612: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:671: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:781: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:782: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:783: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:784: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:791: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:792: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:794: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:796: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1046: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1093: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:59: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:294: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:295: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h:64: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h:65: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h:66: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:225: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:606: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:1520: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:108: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.mm:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:299: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:215: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:218: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:45: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:67: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Plugins/PluginView.cpp:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Plugins/PluginView.cpp:145: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Plugins/PluginView.cpp:224: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:304: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:314: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:330: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:341: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:344: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/DrawingArea.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:177: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:203: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.cpp:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.cpp:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.h:123: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 191 in 94 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 9 2017-06-16 21:44:06 PDT

Created attachment 313184 [details] Patch

Build Bot

Comment 10 2017-06-16 21:47:02 PDT

Attachment 313184 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:63: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2205: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebBackForwardList.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginStream.mm:305: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.cpp:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:105: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:112: Missing space after , [whitespace/comma] [3] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:112: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:125: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:140: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:176: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:195: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:237: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:160: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:167: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:174: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:876: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:876: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:879: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.h:201: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.h:299: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:228: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:50: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:131: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:132: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:116: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:129: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:142: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h:71: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.mm:134: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:48: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginStream.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:443: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/loader/NetscapePlugInStreamLoader.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/loader/NetscapePlugInStreamLoader.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:42: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:92: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:93: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.cpp:720: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:813: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:99: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:361: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:139: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:407: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:296: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.h:42: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIIconLoadingClient.h:42: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIIconLoadingClient.h:42: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebBackForwardList.cpp:398: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxy.h:93: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:426: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:437: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:458: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:469: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:480: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:498: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:509: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:531: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:542: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:553: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:577: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:588: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:620: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:743: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:960: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:1599: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:1624: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2349: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2822: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2833: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2844: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2856: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2868: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2880: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2892: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2918: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6288: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6299: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6310: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6321: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6365: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6585: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6717: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6747: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:433: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:461: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:477: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:505: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:506: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:507: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:511: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:512: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:513: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:514: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:516: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:517: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:519: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:520: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:522: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:524: Extra space bef ore ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:535: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:596: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:597: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:598: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:599: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:610: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:612: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:671: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:781: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:782: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:783: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:784: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:791: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:792: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:794: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:796: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1046: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1093: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:59: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:294: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:295: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h:64: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h:65: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h:66: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:225: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:606: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:1520: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:108: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.mm:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:299: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:215: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:218: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:45: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:67: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Plugins/PluginView.cpp:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Plugins/PluginView.cpp:145: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Plugins/PluginView.cpp:224: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:304: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:314: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:330: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:341: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:344: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/DrawingArea.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:177: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:203: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.cpp:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.cpp:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.h:123: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 191 in 94 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 11 2017-06-17 13:26:52 PDT

Comment on attachment 313184 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313184&action=review I could not discern the pattern for where you were using WTF::Function and where you were using Function without the explicit namespace. If a function need to call a function one or more times before it returns, and is definitely not intending to hold on to the function and call it later, and in fact is not allowed to do so, what’s the best type to use for that argument? WTF::Function&&? const WTF::Function&? Something else? That pattern does seem to come up fairly often. > Source/WebKit2/UIProcess/ProcessAssertion.h:27 > #ifndef ProcessAssertion_h > #define ProcessAssertion_h #pragma once?

WebKit Commit Bot

Comment 12 2017-06-17 13:56:01 PDT

Comment on attachment 313184 [details] Patch Clearing flags on attachment: 313184 Committed r218457: <http://trac.webkit.org/changeset/218457>

WebKit Commit Bot

Comment 13 2017-06-17 13:56:04 PDT

All reviewed patches have been landed. Closing bug.

Chris Dumez

Comment 14 2017-06-17 17:04:38 PDT

(In reply to Darin Adler from comment #11) > Comment on attachment 313184 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=313184&action=review > > I could not discern the pattern for where you were using WTF::Function and > where you were using Function without the explicit namespace. The issue with using Function without WTF:: namespace is that it often conflicts with something else on non-Mac bots. As a result, I tend to prefer using WTF::Function over Function. If people prefer using Function when possible, I do not mind either but this sometimes means try & fail attempts with EWS bots to figure out when WTF:: is required. I think I used Function without namespace in one file in this patch because it was already using Function without namespace in the surroundings. > > If a function need to call a function one or more times before it returns, > and is definitely not intending to hold on to the function and call it > later, and in fact is not allowed to do so, what’s the best type to use for > that argument? WTF::Function&&? const WTF::Function&? Something else? That > pattern does seem to come up fairly often. Hmm. I believe I did not treat those cases any differently for now, meaning that I passed them a WTF::Function&&. That said, thinking about this more, I think it may make more sense to use const WTF::Function& instead. This makes it clear we are not transferring ownership to the callee and it may be useful for the caller to maintain ownership after the call. > > > Source/WebKit2/UIProcess/ProcessAssertion.h:27 > > #ifndef ProcessAssertion_h > > #define ProcessAssertion_h > > #pragma once?

Note You need to log in before you can comment on or make changes to this bug.