Bug 173452

Summary: addTransceiver should trigger mid generation in the SDP
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2017-06-15 18:35:43 PDT
Currently, it is only done if a track is added.
Attachments
Patch (13.00 KB, patch)
2017-06-15 18:41 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (13.09 KB, patch)
2017-06-16 16:28 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-06-15 18:41:16 PDT
Created attachment 313042 [details] Patch
Alex Christensen
Comment 2 2017-06-16 09:21:33 PDT
Comment on attachment 313042 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313042&action=review > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:246 > + rtcOptions.offer_to_receive_audio = 1; kOfferToReceiveMediaTrue > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:248 > + rtcOptions.offer_to_receive_video = 1; kOfferToReceiveMediaTrue
youenn fablet
Comment 3 2017-06-16 16:28:27 PDT
Created attachment 313155 [details] Patch
WebKit Commit Bot
Comment 4 2017-06-16 17:27:36 PDT
Comment on attachment 313155 [details] Patch Clearing flags on attachment: 313155 Committed r218431: <http://trac.webkit.org/changeset/218431>
WebKit Commit Bot
Comment 5 2017-06-16 17:27:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.