Bug 173452

Summary:

addTransceiver should trigger mid generation in the SDP

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Media

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description youenn fablet 2017-06-15 18:35:43 PDT

Currently, it is only done if a track is added.

Comment 1 youenn fablet 2017-06-15 18:41:16 PDT

Created attachment 313042 [details]
Patch

Comment 2 Alex Christensen 2017-06-16 09:21:33 PDT

Comment on attachment 313042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313042&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:246
> +        rtcOptions.offer_to_receive_audio = 1;

kOfferToReceiveMediaTrue

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:248
> +        rtcOptions.offer_to_receive_video = 1;

kOfferToReceiveMediaTrue

Comment 3 youenn fablet 2017-06-16 16:28:27 PDT

Created attachment 313155 [details]
Patch

Comment 4 WebKit Commit Bot 2017-06-16 17:27:36 PDT

Comment on attachment 313155 [details]
Patch

Clearing flags on attachment: 313155

Committed r218431: <http://trac.webkit.org/changeset/218431>

Comment 5 WebKit Commit Bot 2017-06-16 17:27:37 PDT

All reviewed patches have been landed.  Closing bug.