Summary: | Use WTFLogAlways for debug logging so that it shows up in device system logs | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, rniwa, simon.fraser, thorton, zalan | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2017-06-15 17:39:36 PDT
Created attachment 313034 [details]
Patch
With this change, I can't make use of logging in Mac :( It has gotten way too verbose with all the timestamps and whatnot: 2017-06-27 22:15:37.245124-0700 DumpRenderTree[75864:10337285] BODY 0x11bd42548 (renderer 0x11bd76000) (child needs style recalc) BODY 0x11bd42548 (renderer 0x11bd76000) (child needs style recalc) 2017-06-27 22:15:37.804742-0700 DumpRenderTree[75864:10337285] 2017-06-27 22:15:38.310601-0700 DumpRenderTree[75864:10337285] #text 0x11bd73410 "\n\n" #text 0x11bd73410 "\n\n" 2017-06-27 22:15:38.783244-0700 DumpRenderTree[75864:10337285] 2017-06-27 22:15:39.300787-0700 DumpRenderTree[75864:10337285] INPUT 0x11bd6c380 (renderer 0x11bd1c290) (needs style recalc) (child needs style recalc) INPUT 0x11bd6c380 (renderer 0x11bd1c290) (needs style recalc) (child needs style recalc) 2017-06-27 22:15:39.728353-0700 DumpRenderTree[75864:10337285] 2017-06-27 22:15:39.931333-0700 DumpRenderTree[75864:10337285] #document-fragment 0x11bdf8398 (renderer 0x0) (needs style recalc) (child needs style recalc) #document-fragment 0x11bdf8398 (renderer 0x0) (needs style recalc) (child needs style recalc) 2017-06-27 22:15:40.099165-0700 DumpRenderTree[75864:10337285] 2017-06-27 22:15:40.249989-0700 DumpRenderTree[75864:10337285] DIV 0x11bd42618 (renderer 0x11bd0ba20) (child needs style recalc) DIV 0x11bd42618 (renderer 0x11bd0ba20) (child needs style recalc) 2017-06-27 22:15:40.414241-0700 DumpRenderTree[75864:10337285] 2017-06-27 22:15:40.549323-0700 DumpRenderTree[75864:10337285] DIV 0x11bd426e8 (renderer 0x11bd76120) DIV 0x11bd426e8 (renderer 0x11bd76120) Zalan was going to roll this out. We really need to build the log with TextStream and log it in one go. (In reply to Simon Fraser (smfr) from comment #4) > Zalan was going to roll this out. > > We really need to build the log with TextStream and log it in one go. Yeah, that would do the trick. I gotta say I really hate all these noisy logs. I wonder if there's some environmental variable we can set to get rid of the timestamps, etc...? Reverted r218373 for reason: Output is not right Committed r218879: <http://trac.webkit.org/changeset/218879> Created attachment 314739 [details]
Patch
Comment on attachment 314739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314739&action=review > Source/WebCore/rendering/InlineBox.cpp:119 > + stream << boxName() << " " << FloatRect(x(), y(), width(), height()) << " (" << this << ") renderer->(" << &renderer() << ")"; I wonder if you should just add a TextStream& operator<<(TextStream&, const InlineBox&) that dumps this. Does it make sense to add InlineBox::frameRect() or boxRect() that returns the rect? > Source/WebCore/rendering/RenderObject.cpp:1032 > + showRenderTreeLegend(stream); > + root->showRenderSubTreeAndMark(stream, this, 1); The "show" in these names is misleading now. (In reply to Simon Fraser (smfr) from comment #8) > Comment on attachment 314739 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=314739&action=review > > > Source/WebCore/rendering/InlineBox.cpp:119 > > + stream << boxName() << " " << FloatRect(x(), y(), width(), height()) << " (" << this << ") renderer->(" << &renderer() << ")"; > > I wonder if you should just add a TextStream& operator<<(TextStream&, const > InlineBox&) that dumps this. > > Does it make sense to add InlineBox::frameRect() or boxRect() that returns > the rect? I am planning to do that as part of the general InlineBox cleanup. > > > Source/WebCore/rendering/RenderObject.cpp:1032 > > + showRenderTreeLegend(stream); > > + root->showRenderSubTreeAndMark(stream, this, 1); > > The "show" in these names is misleading now. ok. Created attachment 314755 [details]
Patch
Comment on attachment 314755 [details] Patch Clearing flags on attachment: 314755 Committed r219216: <http://trac.webkit.org/changeset/219216> All reviewed patches have been landed. Closing bug. |