Bug 173446 – REGRESSION: AirPlay button is incorrectly highlighted in inline and fullscreen

• Component: Media
• Status: RESOLVED FIXED

[Jon Lee]

When AirPlay is turned on, the icon is incorrectly highlighted.

Navigate to a MediaDocument, then AirPlay the movie to a TV. The highlight surrounds the icon, rather than be the icon itself.

[Radar WebKit Bug Importer]

<rdar://problem/32803667>

[Jon Lee]

This is also true if you take the video fullscreen.

[Antoine Quint]

Created attachment 313030 [details]
Patch

[Build Bot]

Comment on attachment 313030 [details]
Patch

Attachment 313030 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3938622

New failing tests:
media/modern-media-controls/airplay-button/airplay-button-on.html

[Build Bot]

Created attachment 313044 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Antoine Quint]

Created attachment 313050 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 313050 [details]
Patch for landing

Clearing flags on attachment: 313050

Committed r218377: <http://trac.webkit.org/changeset/218377>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Matt Lewis]

After this patch, the test in the patch that was updated media/modern-media-controls/airplay-button/airplay-button-on.html has become flaky on WK1.

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r218498%20(2591)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fairplay-button%2Fairplay-button-on.html

Diff
--- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/airplay-button/airplay-button-on-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/airplay-button/airplay-button-on-actual.txt
@@ -5,7 +5,7 @@
 
 PASS airplayButton.element.classList.contains("on") became true
 PASS window.getComputedStyle(airplayButton.element).backgroundColor became "rgba(0, 0, 0, 0)"
-PASS window.getComputedStyle(airplayButton.image.element).backgroundColor became airplayColor
+
 PASS successfullyParsed is true
 
 TEST COMPLETE



stderr:
ScriptedAnimationController::m_suspendCount = 1
1   0x10e293b59 WebCore::ScriptedAnimationController::logSuspendCount()
2   0x10e293b1e WebCore::ScriptedAnimationController::suspend()
3   0x10c3d0580 WebCore::Document::requestAnimationFrame(WTF::Ref<WebCore::RequestAnimationFrameCallback>&&)
4   0x10c4cfb5c WebCore::DOMWindow::requestAnimationFrame(WTF::Ref<WebCore::RequestAnimationFrameCallback>&&)
5   0x10d0a725c WebCore::jsDOMWindowInstanceFunctionRequestAnimationFrameBody(JSC::ExecState*, WebCore::JSDOMWindow*, JSC::ThrowScope&)
6   0x10d06872e long long WebCore::IDLOperation<WebCore::JSDOMWindow>::call<&(WebCore::jsDOMWindowInstanceFunctionRequestAnimationFrameBody(JSC::ExecState*, WebCore::JSDOMWindow*, JSC::ThrowScope&)), (WebCore::CastedThisErrorBehavior)0>(JSC::ExecState&, char const*)
7   0x10d0684bc WebCore::jsDOMWindowInstanceFunctionRequestAnimationFrame(JSC::ExecState*)
8   0x5f7f14e01028
9   0x103fb9cc2 llint_entry
10  0x103fb9cc2 llint_entry
11  0x103fb9cc2 llint_entry
12  0x103fb9cc2 llint_entry
13  0x103fb9cc2 llint_entry
14  0x103fb9cc2 llint_entry
15  0x103fba03b llint_entry
16  0x103fba03b llint_entry
17  0x103fb236e vmEntryToJavaScript
18  0x103d7a3fe JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*)
19  0x103d299ed JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::ExecState*, JSC::JSObject*)
20  0x103589ec8 JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
21  0x10358a090 JSC::profiledEvaluate(JSC::ExecState*, JSC::ProfilingReason, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
22  0x10e28387b WebCore::JSMainThreadExecState::profiledEvaluate(JSC::ExecState*, JSC::ProfilingReason, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
23  0x10e283668 WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld&, WebCore::ExceptionDetails*)
24  0x10e28395d WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&, WebCore::ExceptionDetails*)
25  0x10e2991b2 WebCore::ScriptElement::executeClassicScript(WebCore::ScriptSourceCode const&)
26  0x10e29758f WebCore::ScriptElement::prepareScript(WTF::TextPosition const&, WebCore::ScriptElement::LegacyTypeSupport)
27  0x10ca33b40 WebCore::HTMLScriptRunner::runScript(WebCore::ScriptElement&, WTF::TextPosition const&)
28  0x10ca339af WebCore::HTMLScriptRunner::execute(WTF::Ref<WebCore::ScriptElement>&&, WTF::TextPosition const&)
29  0x10c957cb2 WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder()
30  0x10c958213 WebCore::HTMLDocumentParser::pumpTokenizerLoop(WebCore::HTMLDocumentParser::SynchronousMode, bool, WebCore::PumpSession&)
31  0x10c956ea8 WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode)

[Antoine Quint]

The flakiness is the same longstanding issue reported in https://bugs.webkit.org/show_bug.cgi?id=168409.