Bug 173443

Summary: Implement basic authentication in MiniBrowser
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Alex Christensen
Reported 2017-06-15 15:48:51 PDT
Implement basic authentication in MiniBrowser
Attachments
Patch (2.88 KB, patch)
2017-06-15 15:49 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.87 KB, patch)
2017-06-15 17:52 PDT, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-06-15 15:49:13 PDT
Created attachment 313019 [details] Patch
Sam Weinig
Comment 2 2017-06-15 16:19:50 PDT
Comment on attachment 313019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313019&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:670 > + [alert beginSheetModalForWindow:self.window completionHandler:^void(NSModalResponse response) I don't think the void is necessary. > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:671 > + { This should go on the previous line.
Alex Christensen
Comment 3 2017-06-15 17:52:19 PDT
Created attachment 313035 [details] Patch
Alex Christensen
Comment 4 2017-06-15 18:09:18 PDT
It would be nice if hitting tab from the user input field would take the focus to the password input field...but as-is this already helps me debug things much more effectively.
Tim Horton
Comment 5 2017-06-16 12:15:08 PDT
(In reply to Alex Christensen from comment #4) > It would be nice if hitting tab from the user input field would take the > focus to the password input field...but as-is this already helps me debug > things much more effectively. setNextKeyView
Alex Christensen
Comment 6 2017-06-16 12:21:37 PDT
Also added a setInitialFirstResponder. https://trac.webkit.org/changeset/218401/webkit
Note You need to log in before you can comment on or make changes to this bug.