Bug 173439

Summary: Modern media controls tests error in Button.js
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, graouts, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=173059
Attachments:
Description Flags
Patch none

Matt Lewis
Reported 2017-06-15 14:27:23 PDT
media/modern-media-controls/buttons-container/buttons-container-constructor.html is a flaky failure on Sierra WK2 Debug, El Capitan WK1 Debug, and iOS Simulator Release WK1 according to the Flakiness Dashboard. the test was re-baselined and re-enabled with: https://trac.webkit.org/changeset/217891/webkit The test seems to have been flaky after additional test were re-enabled and re-baselined: https://trac.webkit.org/changeset/217941/webkit https://trac.webkit.org/changeset/217940/webkit https://trac.webkit.org/changeset/217939/webkit https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r218344%20(1568)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/1568 Diff: --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/buttons-container/buttons-container-constructor-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/buttons-container/buttons-container-constructor-actual.txt @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: line 155: TypeError: null is not an object (evaluating 'this._imageSource.src') Testing the ButtonsContainer constructor. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Attachments
Patch (2.24 KB, patch)
2017-06-15 15:31 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2017-06-15 15:17:09 PDT
Similar failure for media/modern-media-controls/buttons-container/buttons-container-buttons-property.html here: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r218342%20(1567)/media/modern-media-controls/buttons-container/buttons-container-buttons-property-pretty-diff.html
Antoine Quint
Comment 3 2017-06-15 15:31:38 PDT
Created attachment 313018 [details] Patch
WebKit Commit Bot
Comment 4 2017-06-15 16:34:19 PDT
Comment on attachment 313018 [details] Patch Clearing flags on attachment: 313018 Committed r218367: <http://trac.webkit.org/changeset/218367>
WebKit Commit Bot
Comment 5 2017-06-15 16:34:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.