Bug 173435 – Web Inspector: Group Inspector Style Sheets as part of the Stylesheets folder

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

Currently, Inspector Style Sheet resources are only visible in the "All Resources" option.

[Devin Rousso]

Created attachment 313012 [details]
Patch

[Nikita Vasilyev]

Comment on attachment 313012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313012&action=review

> Source/WebInspectorUI/ChangeLog:4
> +        Web Inspector: Group Inspector Style Sheets as part of the Stylesheets folder
> +        https://bugs.webkit.org/show_bug.cgi?id=173435

Would be nice to add a comment to make it clear it's Stylesheets folder in the *Resources* tab.

> Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:230
> +            if (treeElement instanceof WebInspector.CSSStyleSheetTreeElement)
> +                return selectedScopeBarItem[WebInspector.ResourceSidebarPanel.ResourceTypeSymbol] === WebInspector.Resource.Type.Stylesheet;
> +

Non Web Inspector created stylesheets go through the code path a few lines below:

    return treeElement.resource.type === selectedScopeBarItem[WebInspector.ResourceSidebarPanel.ResourceTypeSymbol];

Since a Web Inspector created stylesheet doesn't have treeElement.resource.type, we need a special case.

Did I understand it correctly?

[Joseph Pecoraro]

Comment on attachment 313012 [details]
Patch

This seems fine.

[WebKit Commit Bot]

Comment on attachment 313012 [details]
Patch

Clearing flags on attachment: 313012

Committed r219185: <http://trac.webkit.org/changeset/219185>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.