Summary: | REGRESSION(r218325): [GTK] Runtime critical warnings running layout tests that show a popup menu | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aperez, berto, bugs-noreply, buildbot, clopez, gustavo, mcatanzaro | ||||
Priority: | P2 | Keywords: | Gtk, Regression | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2017-06-15 08:51:56 PDT
This only affect WTR. Created attachment 312986 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 312986 [details]
Patch
Informally reviewing: r+
Was this somehow not caught by the tests? From the ChangeLog description
it sounds that the tests still pass despite the critical warnings.
Comment on attachment 312986 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312986&action=review Any warning ought to cause tests to fail :/ but it probably doesn't work that way currently. > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:211 > + if (WEBKIT_IS_WEB_VIEW(m_viewWidget)) > + return WebKitPopupMenu::create(m_viewWidget, page); > + return WebPopupMenuProxyGtk::create(m_viewWidget, page); It merits a comment to explain the difference, don't you think? Committed r218382: <http://trac.webkit.org/changeset/218382> |