Bug 173416

Summary: [JSC] Add fast path for Object.assign
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 173414    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2017-06-15 05:38:06 PDT
Unless observable behavior happens, we can avoid GetOwnProperty for each key to ensure the key is still enumerable.
Attachments
Patch (6.81 KB, patch)
2017-06-16 13:45 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-06-16 13:45:59 PDT
Created attachment 313125 [details] Patch
Yusuke Suzuki
Comment 2 2017-06-16 13:46:27 PDT
Basic idea is similar to https://bugs.webkit.org/show_bug.cgi?id=163305
Mark Lam
Comment 3 2017-06-16 13:59:29 PDT
Comment on attachment 313125 [details] Patch r=me
Yusuke Suzuki
Comment 4 2017-06-16 14:03:42 PDT
Comment on attachment 313125 [details] Patch Thank you!
WebKit Commit Bot
Comment 5 2017-06-16 14:32:56 PDT
Comment on attachment 313125 [details] Patch Clearing flags on attachment: 313125 Committed r218415: <http://trac.webkit.org/changeset/218415>
WebKit Commit Bot
Comment 6 2017-06-16 14:32:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.