Summary: | [GTK] Do not use the C API in WebGtkExtensionManager | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, buildbot, mcatanzaro, zan | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2017-06-15 04:05:50 PDT
Created attachment 312969 [details]
Patch
Attachment 312969 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/gtk/WebGtkInjectedBundleMain.cpp:22: You should add a blank line after implementation file's own header. [build/include_order] [4]
ERROR: Source/WebKit2/WebProcess/gtk/WebGtkInjectedBundleMain.cpp:22: You should not add a blank line before implementation file's own header. [build/include_order] [4]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 312969 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312969&action=review > Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.cpp:-56 > - ASSERT(userData); Why did you remove this line? I would keep it. Comment on attachment 312969 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312969&action=review > Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.cpp:92 > + ASSERT(userDataObject); Because it's now checked earlier here :-) Committed r218331: <http://trac.webkit.org/changeset/218331> |