Bug 17340

Summary:

WebCore/platform/Timer.cpp fails to build with gcc 4.3

Product:

WebKit

Reporter:

Bernhard Rosenkraenzer <bero>

Component:

WebCore Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Linux

Attachments:

Description	Flags
fix	darin: review+

Description Bernhard Rosenkraenzer 2008-02-13 02:32:44 PST

../../../WebCore/platform/Timer.cpp: In function 'bool WebCore::operator<(const WebCore::TimerHeapElement&, const WebCore::TimerHeapElement&)':
../../../WebCore/platform/Timer.cpp:107: error: 'UINT_MAX' was not declared in this scope
make[1]: *** [tmp/Timer.o] Error 1


UINT_MAX is defined in <limits.h>, which isn't being #included.

Comment 1 Bernhard Rosenkraenzer 2008-02-13 02:33:28 PST

This happens to work with older versions of gcc because

#include <limits>

used to #include <climits> as well. gcc 4.3 trims down on header interdependencies

Comment 2 Bernhard Rosenkraenzer 2008-02-13 02:36:02 PST

Created attachment 19108 [details]
fix

Comment 3 Darin Adler 2008-02-13 04:12:58 PST

Comment on attachment 19108 [details]
fix

We would use <limits.h> rather that <climits>.

Comment 4 Darin Adler 2008-02-13 04:28:27 PST

Again had to remove tabs and apply the patch by hand.

Committed revision 30193.