Bug 173395

Summary:

[WebIDL] Add support for serializers that have members that are themselves serializers (or inherit being a serializer from a parent)

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

Bindings

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, dbates, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=163534

Attachments:

Description	Flags
WIP	none
Patch	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Patch	none

Sam Weinig

Reported 2017-06-14 17:54:01 PDT

We need to add support for serializers that have members that are themselves serializers (or inherit being a serializer from a parent). DOMQuad uses this as it has attributes that are DOMPoints, which inherit being a serializer through DOMPointReadOnly.

Attachments
WIP (24.07 KB, patch) 2017-06-14 17:54 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (35.11 KB, patch) 2017-06-18 18:30 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (982.71 KB, application/zip) 2017-06-18 19:37 PDT, Build Bot	no flags	Details
Patch (30.77 KB, patch) 2017-06-18 20:33 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2017-06-14 17:54:28 PDT

Created attachment 312939 [details] WIP

Sam Weinig

Comment 2 2017-06-18 18:30:30 PDT Comment hidden (obsolete)

Created attachment 313251 [details] Patch

Build Bot

Comment 3 2017-06-18 19:37:40 PDT Comment hidden (obsolete)

Comment on attachment 313251 [details] Patch Attachment 313251 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3954946 New failing tests: inspector/canvas/create-canvas-contexts.html

Build Bot

Comment 4 2017-06-18 19:37:41 PDT Comment hidden (obsolete)

Created attachment 313257 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Sam Weinig

Comment 5 2017-06-18 20:33:21 PDT

Created attachment 313259 [details] Patch

Simon Fraser (smfr)

Comment 6 2017-06-19 13:11:46 PDT

Comment on attachment 313259 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313259&action=review > Source/WebCore/bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:18 > + This library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Library General Public > + License as published by the Free Software Foundation; either > + version 2 of the License, or (at your option) any later version. > + > + This library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Library General Public License for more details. > + > + You should have received a copy of the GNU Library General Public License > + along with this library; see the file COPYING.LIB. If not, write to > + the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, > + Boston, MA 02110-1301, USA. Do we really put LGPL on new generated files? > LayoutTests/fast/css/DOMQuad-serialization.html:1 > +<!DOCTYPE html> This might already be tested by web platform tests?

Sam Weinig

Comment 7 2017-06-19 14:25:17 PDT

(In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 313259 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=313259&action=review > > > Source/WebCore/bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:18 > > + This library is free software; you can redistribute it and/or > > + modify it under the terms of the GNU Library General Public > > + License as published by the Free Software Foundation; either > > + version 2 of the License, or (at your option) any later version. > > + > > + This library is distributed in the hope that it will be useful, > > + but WITHOUT ANY WARRANTY; without even the implied warranty of > > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + Library General Public License for more details. > > + > > + You should have received a copy of the GNU Library General Public License > > + along with this library; see the file COPYING.LIB. If not, write to > > + the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, > > + Boston, MA 02110-1301, USA. > > Do we really put LGPL on new generated files? Yup. > > > LayoutTests/fast/css/DOMQuad-serialization.html:1 > > +<!DOCTYPE html> > > This might already be tested by web platform tests? I don't think it is. Otherwise, I think the test would be failing.

WebKit Commit Bot

Comment 8 2017-06-19 14:55:04 PDT

Comment on attachment 313259 [details] Patch Clearing flags on attachment: 313259 Committed r218511: <http://trac.webkit.org/changeset/218511>

WebKit Commit Bot

Comment 9 2017-06-19 14:55:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.