Bug 173385

Summary: Implement FALLTHROUGH macro for compilers other than Clang
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Web Template FrameworkAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, buildbot, cdumez, cmarcelo, darin, dbates, joepeck, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Konstantin Tokarev
Reported 2017-06-14 14:36:47 PDT
FALLTHROUGH should be able to use [[gnu::fallthrough]] attribute of GCC, and [[fallthrough]] from C++17, whichever is available.
Attachments
Patch (2.22 KB, patch)
2017-06-14 14:39 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (2.27 KB, patch)
2017-06-15 01:48 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2017-06-14 14:39:11 PDT
Created attachment 312921 [details] Patch
Build Bot
Comment 2 2017-06-14 14:40:22 PDT
Attachment 312921 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Compiler.h:208: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WTF/wtf/Compiler.h:212: Extra space before [. [whitespace/brackets] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Catanzaro
Comment 3 2017-06-14 20:28:11 PDT
Comment on attachment 312921 [details] Patch All the EWS bots are red, fix it please: In file included from ../../Source/WTF/wtf/Platform.h:32:0, from ../../Source/WTF/wtf/ExportMacros.h:32, from ../../Source/JavaScriptCore/runtime/JSExportMacros.h:32, from ../../Source/JavaScriptCore/config.h:26, from /home/ews/ltilve-gtk-wk2-ews/WebKit/Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:27: ../../Source/WTF/wtf/Compiler.h:209:32: error: missing ')' after "__has_attribute" #elif __has_cpp_attribute(clang::fallthrough) ^ ../../Source/WTF/wtf/Compiler.h:209:33: error: ':' without preceding '?' #elif __has_cpp_attribute(clang::fallthrough) ^ ../../Source/WTF/wtf/Compiler.h:211:30: error: missing ')' after "__has_attribute" #elif __has_cpp_attribute(gnu::fallthrough) ^ ../../Source/WTF/wtf/Compiler.h:211:31: error: ':' without preceding '?' #elif __has_cpp_attribute(gnu::fallthrough) ^
Konstantin Tokarev
Comment 4 2017-06-15 01:48:48 PDT
Created attachment 312960 [details] Patch
Build Bot
Comment 5 2017-06-15 01:54:20 PDT
Attachment 312960 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Compiler.h:208: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WTF/wtf/Compiler.h:212: Extra space before [. [whitespace/brackets] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Konstantin Tokarev
Comment 6 2017-06-15 09:14:23 PDT
Comment on attachment 312960 [details] Patch Clearing flags on attachment: 312960 Committed r218333: <http://trac.webkit.org/changeset/218333>
Konstantin Tokarev
Comment 7 2017-06-15 09:14:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.