Bug 173367 – WKErrorGetErrorCode should not return the API::Error enum values directly

• Component: WebKit2
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

Even if the values are the same, we should use a switch to ensure we return the C API values and tot all API::Error enum values are exposed in the C API

[Carlos Garcia Campos]

Created attachment 312891 [details]
Patch

[Alex Christensen]

Comment on attachment 312891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312891&action=review

> Source/WebKit2/Shared/API/c/WKErrorRef.cpp:79
> +    default:
> +        break;

Do we need this default?  If we are switching on enum values, a default would prevent us from finding the bug of missing one of the enum values.  Let's remove the default if we can.

[Carlos Garcia Campos]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 312891 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312891&action=review
> 
> > Source/WebKit2/Shared/API/c/WKErrorRef.cpp:79
> > +    default:
> > +        break;
> 
> Do we need this default?  If we are switching on enum values, a default
> would prevent us from finding the bug of missing one of the enum values. 
> Let's remove the default if we can.

Yes, because not all API::Error values are exposed in the C API.

[Build Bot]

Comment on attachment 312891 [details]
Patch

Attachment 312891 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3929918

New failing tests:
http/tests/misc/window-dot-stop.html
security/block-test.html
http/tests/misc/will-send-request-returns-null-on-redirect.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
http/tests/cache/cancel-multiple-post-xhrs.html
security/block-test-no-port.html
http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html
http/tests/xmlhttprequest/abort-should-cancel-load.html
http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict.html
http/tests/security/XFrameOptions/x-frame-options-deny.html

[Build Bot]

Created attachment 312895 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Carlos Garcia Campos]

It seems we should just return the integer value in case of an error without a name in the C API.

--- /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/layout-test-results/http/tests/cache/cancel-multiple-post-xhrs-expected.txt
+++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/layout-test-results/http/tests/cache/cancel-multiple-post-xhrs-actual.txt
@@ -1,7 +1,7 @@
 http://127.0.0.1:8000/cache/resources/empty.txt - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/cache/resources/empty.txt, main document URL http://127.0.0.1:8000/cache/cancel-multiple-post-xhrs.html, http method POST> redirectResponse (null)
 http://127.0.0.1:8000/cache/resources/empty.txt - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/cache/resources/empty.txt, main document URL http://127.0.0.1:8000/cache/cancel-multiple-post-xhrs.html, http method POST> redirectResponse (null)
 http://127.0.0.1:8000/cache/resources/empty.txt - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/cache/resources/empty.txt, main document URL http://127.0.0.1:8000/cache/cancel-multiple-post-xhrs.html, http method POST> redirectResponse (null)
-http://127.0.0.1:8000/cache/resources/empty.txt - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code -999, failing URL "http://127.0.0.1:8000/cache/resources/empty.txt">
-http://127.0.0.1:8000/cache/resources/empty.txt - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code -999, failing URL "http://127.0.0.1:8000/cache/resources/empty.txt">
-http://127.0.0.1:8000/cache/resources/empty.txt - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code -999, failing URL "http://127.0.0.1:8000/cache/resources/empty.txt">
+http://127.0.0.1:8000/cache/resources/empty.txt - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code 300, failing URL "http://127.0.0.1:8000/cache/resources/empty.txt">
+http://127.0.0.1:8000/cache/resources/empty.txt - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code 300, failing URL "http://127.0.0.1:8000/cache/resources/empty.txt">
+http://127.0.0.1:8000/cache/resources/empty.txt - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code 300, failing URL "http://127.0.0.1:8000/cache/resources/empty.txt">

[Build Bot]

Comment on attachment 312891 [details]
Patch

Attachment 312891 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3929983

New failing tests:
http/tests/misc/window-dot-stop.html
security/block-test.html
http/tests/misc/will-send-request-returns-null-on-redirect.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
http/tests/cache/cancel-multiple-post-xhrs.html
security/block-test-no-port.html
http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html
http/tests/xmlhttprequest/abort-should-cancel-load.html
http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict.html
http/tests/security/XFrameOptions/x-frame-options-deny.html

[Build Bot]

Created attachment 312898 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Carlos Garcia Campos]

Created attachment 312900 [details]
Patch for landing

[Carlos Garcia Campos]

Committed r218315: <http://trac.webkit.org/changeset/218315>