Bug 173359 – [Mac] Add an experimental feature setting for fast frame scrolling

• Component: Frames
• Status: RESOLVED FIXED

[Frédéric Wang (:fredw)]

This will allow developers to test fast-scrollable frames on Mac, without having to change defaultScrollingTreeIncludesFrames.

[Frédéric Wang (:fredw)]

Created attachment 312889 [details]
Patch

[Frédéric Wang (:fredw)]

Created attachment 312890 [details]
Patch

[Build Bot]

Comment on attachment 312890 [details]
Patch

Attachment 312890 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3929927

New failing tests:
platform/mac/fast/scrolling/set-fast-frame-scrolling.html

[Build Bot]

Created attachment 312892 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 312890 [details]
Patch

Attachment 312890 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3929934

New failing tests:
platform/mac/fast/scrolling/set-fast-frame-scrolling.html

[Build Bot]

Created attachment 312894 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 312890 [details]
Patch

Attachment 312890 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3929949

New failing tests:
platform/mac/fast/scrolling/set-fast-frame-scrolling.html

[Build Bot]

Created attachment 312899 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Sam Weinig]

Comment on attachment 312890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312890&action=review

> Source/WebCore/page/RuntimeEnabledFeatures.h:167
> +#if PLATFORM(MAC)
> +    void setFastFrameScrollingEnabled(bool isEnabled) { m_isFastFrameScrollingEnabled = isEnabled; }
> +    bool fastFrameScrollingEnabled() const { return m_isFastFrameScrollingEnabled; }
> +#endif

Why can't this be a Setting?

[Frédéric Wang (:fredw)]

Created attachment 312918 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 312918 [details]
Patch

Why isn't fast frame scrolling a Setting?

[Frédéric Wang (:fredw)]

Comment on attachment 312918 [details]
Patch

After discussion with Simon on irc, all what we want is a settings for "Fast Frame Scrolling" that can be an "experimental feature" (e.g. like SpringTimingFunctionEnabled) not a "runtime flag" (deprecated). I'll upload a new patch soon.

[Frédéric Wang (:fredw)]

Created attachment 313272 [details]
Patch

[Build Bot]

Comment on attachment 313272 [details]
Patch

Attachment 313272 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3956806

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 313273 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 313272 [details]
Patch

Attachment 313272 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3956823

New failing tests:
inspector/canvas/create-canvas-contexts.html

[Build Bot]

Created attachment 313274 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Frédéric Wang (:fredw)]

Created attachment 313279 [details]
Patch

[Frédéric Wang (:fredw)]

Created attachment 313289 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 313289 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313289&action=review

> Source/WebCore/page/Settings.in:179
> +fastFrameScrollingEnabled initial=false

I wonder if we should call this "asyncScrolling" since we have AsyncScrollingCoordinator.

[Frédéric Wang (:fredw)]

Committed r218534: <http://trac.webkit.org/changeset/218534>