Bug 173351

Summary: [GTK] Use API::InjectedBundleClient in WebKitInjectedBundleClient
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, berto, bugs-noreply, buildbot, gustavo, mcatanzaro, zan
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 173350    
Bug Blocks:    
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2017-06-14 00:39:01 PDT
Instead of the C API.
Attachments
Patch (14.69 KB, patch)
2017-06-14 00:42 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-06-14 00:42:31 PDT
Created attachment 312867 [details] Patch
Build Bot
Comment 2 2017-06-14 00:45:19 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Adrian Perez
Comment 3 2017-06-14 01:16:23 PDT
Comment on attachment 312867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312867&action=review Informally reviewing... r+, but let's make sure the EWS is happy and can find the header before landing :-) > Source/WebKit2/UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:23 > +#include "APIInjectedBundleClient.h" According to the EWS this header cannot be found. Please double-check that.
Carlos Garcia Campos
Comment 4 2017-06-14 01:18:47 PDT
Because it depends on #173350
Carlos Garcia Campos
Comment 5 2017-06-14 09:24:42 PDT
Committed r218262: <http://trac.webkit.org/changeset/218262>
Note You need to log in before you can comment on or make changes to this bug.