Summary: | REGRESSION: 15 new jsc failures in WPE and GTK+ | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Claudio Saavedra <csaavedra> | ||||
Component: | JavaScriptCore | Assignee: | Claudio Saavedra <csaavedra> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, jfbastien, ossy | ||||
Priority: | P2 | ||||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Claudio Saavedra
2017-06-14 00:26:32 PDT
Interesting. What happens when you run the tests manually? Something like: cd JSTests/wasm && jsc -m function-tests/memory-alignment.js I definitely fixed alignment checking in that patch, but it should all pass! $ ../../WebKitBuild/Release/bin/jsc -m function-tests/memory-alignment.js Exception: Error: Expected to throw a CompileError with message "WebAssembly.Module doesn't parse at byte 5 / 8: byte alignment 2 exceeds load's natural alignment 1, in function at index 0" _fail@/home/claudio/git/metrological/WebKit/JSTests/wasm/assert.js:27:20 _throws@/home/claudio/git/metrological/WebKit/JSTests/wasm/assert.js:135:10 module code@/home/claudio/git/metrological/WebKit/JSTests/wasm/function-tests/memory-alignment.js:45:26 evaluate@[native code] moduleEvaluation@[native code] [native code] promiseReactionJob@[native code] That's odd, this part of the change should handle that failing case: https://trac.webkit.org/changeset/218216/webkit#file66 Maybe the bots didn't re-generateWasmOps.h during incremental build? Maybe the cmake build is missing a dependency on generateWasm.py. I removed WasmOps.h and after building, the generated file was different. Now running the same test has no output, so I assume it's passing. You're probably right that a dependency is missing. (In reply to Claudio Saavedra from comment #4) > I removed WasmOps.h and after building, the generated file was different. > Now running the same test has no output, so I assume it's passing. You're > probably right that a dependency is missing. Ah good. Could you take a look at the cmake dependency issue? The system I'm on right now is unhappy with cmake so I can't test it. Yes, I'm doing that. (In reply to Claudio Saavedra from comment #6) > Yes, I'm doing that. Actually it looks like it's not only a cmake problem: https://bugs.webkit.org/show_bug.cgi?id=173287 I think Source/JavaScriptCore/DerivedSources.make has an issue (but maybe Source/JavaScriptCore/CMakeLists.txt does too). Created attachment 312902 [details]
Patch
(In reply to JF Bastien from comment #7) > (In reply to Claudio Saavedra from comment #6) > > Yes, I'm doing that. > > I think Source/JavaScriptCore/DerivedSources.make has an issue (but maybe > Source/JavaScriptCore/CMakeLists.txt does too). The above patch seems enough to fix the issue in CMake. Comment on attachment 312902 [details]
Patch
Great, thanks!
Ossy, could you wipe WasmOps.h from all Linux bots? They'll fail until at least this file is rebuilt. Comment on attachment 312902 [details] Patch Clearing flags on attachment: 312902 Committed r218272: <http://trac.webkit.org/changeset/218272> All reviewed patches have been landed. Closing bug. (In reply to JF Bastien from comment #11) > Ossy, could you wipe WasmOps.h from all Linux bots? They'll fail until at > least this file is rebuilt. We did for the GTK+ and WPE bots already. (In reply to JF Bastien from comment #11) > Ossy, could you wipe WasmOps.h from all Linux bots? They'll fail until at > least this file is rebuilt. I triggered clean build on the AArch64 bot, it is happy now, thanks. |