Summary: | WebsitePolicies: let clients select specific autoplay quirks | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Rajca <mrajca> | ||||
Component: | Media | Assignee: | Matt Rajca <mrajca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, buildbot | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Matt Rajca
2017-06-13 17:10:05 PDT
Created attachment 312833 [details]
Patch
Attachment 312833 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:462: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:477: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/_WKWebsitePolicies.h:37: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 3 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Style checks seems like false positive, e.g. Source/WebKit2/UIProcess/API/Cocoa/_WKWebsitePolicies.h:37 is an NS_OPTIONS not a function. Committed r218229: <http://trac.webkit.org/changeset/218229> |