Bug 173343

Summary: WebsitePolicies: let clients select specific autoplay quirks
Product: WebKit Reporter: Matt Rajca <mrajca>
Component: MediaAssignee: Matt Rajca <mrajca>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch achristensen: review+

Matt Rajca
Reported 2017-06-13 17:10:05 PDT
Currently, "allowsAutoplayQuirks" controls both the play/pause quirk and the inherits media user gesture quirk. Give clients the flexibility to set these selectively.
Attachments
Patch (20.94 KB, patch)
2017-06-13 17:16 PDT, Matt Rajca 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Rajca
Comment 1 2017-06-13 17:16:32 PDT
Created attachment 312833 [details] Patch
Build Bot
Comment 2 2017-06-13 17:19:42 PDT
Attachment 312833 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:462: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:477: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/_WKWebsitePolicies.h:37: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Matt Rajca
Comment 3 2017-06-13 17:30:09 PDT
Style checks seems like false positive, e.g. Source/WebKit2/UIProcess/API/Cocoa/_WKWebsitePolicies.h:37 is an NS_OPTIONS not a function.
Matt Rajca
Comment 4 2017-06-13 17:32:26 PDT
Committed r218229: <http://trac.webkit.org/changeset/218229>
Note You need to log in before you can comment on or make changes to this bug.