Bug 173315

Summary:

[WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bugs-noreply, csaavedra, darin, lforschler

Priority:

Keywords:

Gtk, LayoutTestFailure

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Carlos Garcia Campos

Reported 2017-06-13 08:57:18 PDT

This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been destroyed. Thread 1 (Thread 0x7fafced2af00 (LWP 31298)): #0 0x0000000000000041 in ?? () #1 0x00007fafde78baa2 in WebKit::WebGeolocationManagerProxy::~WebGeolocationManagerProxy() () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #2 0x00007fafde7c7d56 in WebKit::WebProcessPool::~WebProcessPool() () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #3 0x00007fafde7c8639 in WebKit::WebProcessPool::~WebProcessPool() () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #4 0x00007fafe10b2019 in WTR::TestController::generatePageConfiguration(OpaqueWKContextConfiguration const*) () #5 0x00007fafe10b7d6b in WTR::TestController::createWebViewWithOptions(WTR::TestOptions const&) () #6 0x00007fafe10b8223 in WTR::TestController::ensureViewSupportsOptionsForTest(WTR::TestInvocation const&) () #7 0x00007fafe10b8421 in WTR::TestController::configureViewForTest(WTR::TestInvocation const&) () #8 0x00007fafe10c0a31 in WTR::TestInvocation::invoke() () #9 0x00007fafe10b369c in WTR::TestController::runTest(char const*) () #10 0x00007fafe10b386b in WTR::TestController::runTestingServerLoop() () #11 0x00007fafe10b6038 in WTR::TestController::TestController(int, char const**) () #12 0x00007fafe10acf9c in main ()

Attachments
Patch (2.85 KB, patch) 2017-06-13 09:00 PDT, Carlos Garcia Campos	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2017-06-13 09:00:43 PDT

Created attachment 312775 [details] Patch

Carlos Garcia Campos

Comment 2 2017-06-13 10:49:00 PDT

Committed r218183: <http://trac.webkit.org/changeset/218183>

Note You need to log in before you can comment on or make changes to this bug.