Bug 173194

Summary: Use WTF::Function instead of std::function in DataURLDecoder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, buildbot, koivisto, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch sam: review+

Chris Dumez
Reported 2017-06-09 16:45:27 PDT
Use WTF::Function instead of std::function in DataURLDecoder, to avoid copying.
Attachments
Patch (3.12 KB, patch)
2017-06-09 16:46 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.08 KB, patch)
2017-06-09 18:36 PDT, Chris Dumez 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-06-09 16:46:18 PDT
Created attachment 312510 [details] Patch
Build Bot
Comment 2 2017-06-09 16:47:37 PDT
Attachment 312510 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/DataURLDecoder.h:52: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3 2017-06-09 18:36:25 PDT
Created attachment 312528 [details] Patch
Build Bot
Comment 4 2017-06-09 18:38:30 PDT
Attachment 312528 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/DataURLDecoder.h:52: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 5 2017-06-09 18:56:20 PDT
The Mac linking errors do not make sense. I think Mac-EWS bots are in a bad state.
Sam Weinig
Comment 6 2017-06-09 20:43:30 PDT
Comment on attachment 312528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312528&action=review > Source/WebCore/platform/network/DataURLDecoder.cpp:57 > + { } I prefer these on separate lines.
Chris Dumez
Comment 7 2017-06-09 21:07:27 PDT
Committed r218039: <http://trac.webkit.org/changeset/218039>
Chris Dumez
Comment 8 2017-06-09 21:39:45 PDT
Follow-up build fix in https://trac.webkit.org/r218040.
Note You need to log in before you can comment on or make changes to this bug.