Bug 173175

Summary: Update Thread::create() to take in a WTF::Function instead of a std::function
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, benjamin, buildbot, cmarcelo, commit-queue, dbates, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-06-09 11:41:36 PDT
Update Thread::create() to take in a WTF::Function instead of a std::function.
Attachments
Patch (3.93 KB, patch)
2017-06-09 11:42 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.32 KB, patch)
2017-06-09 12:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.32 KB, patch)
2017-06-09 12:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-06-09 11:42:22 PDT
Created attachment 312465 [details] Patch
Mark Lam
Comment 2 2017-06-09 12:01:57 PDT
Comment on attachment 312465 [details] Patch r=me but please document the rationale for this change in the ChangeLog.
Chris Dumez
Comment 3 2017-06-09 12:03:01 PDT
Created attachment 312468 [details] Patch
Mark Lam
Comment 4 2017-06-09 12:05:43 PDT
Comment on attachment 312468 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312468&action=review > Source/WTF/ChangeLog:10 > + variables. Doing captures such as [string = string.isolayedCopy()] when passing an typo: /string.isolayedCopy/string.isolatedCopy/
Chris Dumez
Comment 5 2017-06-09 12:07:06 PDT
Created attachment 312469 [details] Patch
WebKit Commit Bot
Comment 6 2017-06-09 12:41:16 PDT
Comment on attachment 312469 [details] Patch Clearing flags on attachment: 312469 Committed r218012: <http://trac.webkit.org/changeset/218012>
WebKit Commit Bot
Comment 7 2017-06-09 12:41:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.