Bug 173174

Summary: Make sure we protect |this| in lambdas in WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, darin, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-06-09 11:37:42 PDT
Make sure we protect |this| in lambdas in WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver().
Attachments
Patch (2.49 KB, patch)
2017-06-09 11:39 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.49 KB, patch)
2017-06-09 11:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-06-09 11:37:58 PDT
<rdar://problem/32598919>
Chris Dumez
Comment 2 2017-06-09 11:39:39 PDT
Created attachment 312464 [details] Patch
Chris Dumez
Comment 3 2017-06-09 11:44:01 PDT
Created attachment 312466 [details] Patch
Darin Adler
Comment 4 2017-06-09 11:49:58 PDT
Comment on attachment 312466 [details] Patch Looks good to me. After this change, though, WebResourceLoadStatisticsStore::processStatisticsAndDataRecords is the one remaining lambda that captures [this], but does not ref/deref it. The one passed to coreStore().processStatistics. Perhaps that function is guaranteed to run synchronously?
Chris Dumez
Comment 5 2017-06-09 11:50:42 PDT
(In reply to Darin Adler from comment #4) > Comment on attachment 312466 [details] > Patch > > Looks good to me. > > After this change, though, > WebResourceLoadStatisticsStore::processStatisticsAndDataRecords is the one > remaining lambda that captures [this], but does not ref/deref it. The one > passed to coreStore().processStatistics. Perhaps that function is guaranteed > to run synchronously? That one is safe because it is synchronous.
Chris Dumez
Comment 6 2017-06-09 11:52:13 PDT
Comment on attachment 312466 [details] Patch Clearing flags on attachment: 312466 Committed r218006: <http://trac.webkit.org/changeset/218006>
Chris Dumez
Comment 7 2017-06-09 11:52:14 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 8 2017-06-09 15:17:40 PDT
Landed a follow-up fix in https://trac.webkit.org/r218022.
Note You need to log in before you can comment on or make changes to this bug.