Bug 173167

Summary: [WTF] Drop unnecessary includes in Threading.h
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, commit-queue, darin, dbates, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+, commit-queue: commit-queue-

Yusuke Suzuki
Reported 2017-06-09 09:55:37 PDT
[WTF] Drop unnecessary includes in Threading.h
Attachments
Patch (3.05 KB, patch)
2017-06-09 09:56 PDT, Yusuke Suzuki 		darin: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-06-09 09:56:56 PDT
Created attachment 312446 [details] Patch
WebKit Commit Bot
Comment 2 2017-06-10 00:55:29 PDT
Comment on attachment 312446 [details] Patch Rejecting attachment 312446 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 312446, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: g file Source/WTF/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WTF/wtf/Assertions.cpp patching file Source/WTF/wtf/LocklessBag.h patching file Source/WTF/wtf/Threading.h Hunk #1 FAILED at 31. 1 out of 1 hunk FAILED -- saving rejects to file Source/WTF/wtf/Threading.h.rej patching file Source/WTF/wtf/ThreadingPrimitives.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3906094
Yusuke Suzuki
Comment 3 2017-06-11 09:56:16 PDT
oh, I thought this is landed. But cq is failed due to conflict. I'll land it manually.
Yusuke Suzuki
Comment 4 2017-06-11 09:59:32 PDT
Committed r218069: <http://trac.webkit.org/changeset/218069>
Note You need to log in before you can comment on or make changes to this bug.