Bug 173165

Summary:

Update WorkQueue::concurrentApply() to take a WTF::Function instead of an std::function

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Template Framework

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, beidson, benjamin, bfulgham, buildbot, cmarcelo, commit-queue, dbates, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2017-06-09 09:38:46 PDT

Update WorkQueue::concurrentApply() to take a WTF::Function instead of an std::function.

Attachments
Patch (2.52 KB, patch) 2017-06-09 09:40 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (4.41 KB, patch) 2017-06-09 09:54 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (4.61 KB, patch) 2017-06-09 09:57 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (4.61 KB, patch) 2017-06-09 10:20 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-06-09 09:40:42 PDT

Created attachment 312443 [details] Patch

Chris Dumez

Comment 2 2017-06-09 09:54:14 PDT

Created attachment 312445 [details] Patch

Build Bot

Comment 3 2017-06-09 09:56:56 PDT

Attachment 312445 [details] did not pass style-queue: ERROR: Source/WTF/wtf/WorkQueue.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.cpp:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.cpp:115: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 4 2017-06-09 09:57:57 PDT

Created attachment 312448 [details] Patch

Build Bot

Comment 5 2017-06-09 10:01:27 PDT

Attachment 312448 [details] did not pass style-queue: ERROR: Source/WTF/wtf/WorkQueue.cpp:59: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.cpp:116: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 6 2017-06-09 10:20:45 PDT

Created attachment 312451 [details] Patch

Build Bot

Comment 7 2017-06-09 10:22:46 PDT

Attachment 312451 [details] did not pass style-queue: ERROR: Source/WTF/wtf/WorkQueue.cpp:59: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.cpp:116: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 8 2017-06-09 10:54:20 PDT

Comment on attachment 312451 [details] Patch Clearing flags on attachment: 312451 Committed r217998: <http://trac.webkit.org/changeset/217998>

Chris Dumez

Comment 9 2017-06-09 10:54:22 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.