Summary: | Add API::IconDatabaseClient | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, andersca, darin | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 173146 | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2017-06-09 03:30:34 PDT
Created attachment 312418 [details]
Patch
Comment on attachment 312418 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312418&action=review > Source/WebKit2/UIProcess/WebIconDatabase.h:118 > + std::unique_ptr<API::IconDatabaseClient> m_client; I think this is wrong. Usually we have the API object own the WebKit namespace object. Comment on attachment 312418 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312418&action=review >> Source/WebKit2/UIProcess/WebIconDatabase.h:118 >> + std::unique_ptr<API::IconDatabaseClient> m_client; > > I think this is wrong. Usually we have the API object own the WebKit namespace object. Could you point to an example? I think I've followed what all other objects do. - WebPageProxy in WebKit namespace owns API::LoaderClient, API::PolicyClient, API::NavigationClient, and a lot more clients - WebProcessPool in WebKit namespace owns API::AutomationClient, API::DownloadClient, API::LegacyContextHistoryClient and API::CustomProtocolManagerClient or did I misunderstand what you mean? Comment on attachment 312418 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312418&action=review > Source/WebKit2/UIProcess/API/APIIconDatabaseClient.h:2 > + * Copyright (C) 2014 Apple Inc. All rights reserved. 2017 >>> Source/WebKit2/UIProcess/WebIconDatabase.h:118 >>> + std::unique_ptr<API::IconDatabaseClient> m_client; >> >> I think this is wrong. Usually we have the API object own the WebKit namespace object. > > Could you point to an example? I think I've followed what all other objects do. > > - WebPageProxy in WebKit namespace owns API::LoaderClient, API::PolicyClient, API::NavigationClient, and a lot more clients > - WebProcessPool in WebKit namespace owns API::AutomationClient, API::DownloadClient, API::LegacyContextHistoryClient and API::CustomProtocolManagerClient > > or did I misunderstand what you mean? After talking to some people, I now think this is correct. Sorry about the misunderstanding. API namespace objects own WebKit namespace objects, but clients pass calls in the opposite direction. This is correct. We should us a UniqueRef here because it's never null. (In reply to Alex Christensen from comment #4) > Comment on attachment 312418 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312418&action=review > > > Source/WebKit2/UIProcess/API/APIIconDatabaseClient.h:2 > > + * Copyright (C) 2014 Apple Inc. All rights reserved. > > 2017 > > >>> Source/WebKit2/UIProcess/WebIconDatabase.h:118 > >>> + std::unique_ptr<API::IconDatabaseClient> m_client; > >> > >> I think this is wrong. Usually we have the API object own the WebKit namespace object. > > > > Could you point to an example? I think I've followed what all other objects do. > > > > - WebPageProxy in WebKit namespace owns API::LoaderClient, API::PolicyClient, API::NavigationClient, and a lot more clients > > - WebProcessPool in WebKit namespace owns API::AutomationClient, API::DownloadClient, API::LegacyContextHistoryClient and API::CustomProtocolManagerClient > > > > or did I misunderstand what you mean? > > After talking to some people, I now think this is correct. Sorry about the > misunderstanding. np, the whole thing is indeed confusing at first. > API namespace objects own WebKit namespace objects, but > clients pass calls in the opposite direction. This is correct. > We should us a UniqueRef here because it's never null. Didn't know UniqueRef, do you want me to change this patch before landing to use UniqueRef, or better do that in a follow up and switch all clients to UniqueRef? Switching all clients to UniqueRef would be nice. (In reply to Alex Christensen from comment #6) > Switching all clients to UniqueRef would be nice. Then I'll keep this simple and switch all clients in a follow up. Committed r218107: <http://trac.webkit.org/changeset/218107> |