Bug 173137

Summary: [GTK] Handle page download request in WebKitWebView directly
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, buildbot, gustavo, mcatanzaro, zan
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Carlos Garcia Campos
Reported 2017-06-09 00:24:47 PDT
We don't need to pass through WebKitWebViewBase, since the base doesn't an implementation.
Attachments
Patch (7.19 KB, patch)
2017-06-09 00:27 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-06-09 00:27:00 PDT
Created attachment 312400 [details] Patch
Build Bot
Comment 2 2017-06-09 00:28:34 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Zan Dobersek
Comment 3 2017-06-09 01:00:32 PDT
Comment on attachment 312400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312400&action=review > Source/WebKit2/ChangeLog:8 > + We don't need to pass through WebKitWebViewBase, since the base doesn't an implementation. You dropped a word there.
Carlos Garcia Campos
Comment 4 2017-06-10 23:28:13 PDT
Committed r218063: <http://trac.webkit.org/changeset/218063>
Note You need to log in before you can comment on or make changes to this bug.