Bug 173137

Summary:

[GTK] Handle page download request in WebKitWebView directly

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, bugs-noreply, buildbot, gustavo, mcatanzaro, zan

Priority:

Keywords:

Gtk

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	zan: review+

Description Carlos Garcia Campos 2017-06-09 00:24:47 PDT

We don't need to pass through WebKitWebViewBase, since the base doesn't an implementation.

Comment 1 Carlos Garcia Campos 2017-06-09 00:27:00 PDT

Created attachment 312400 [details]
Patch

Comment 2 Build Bot 2017-06-09 00:28:34 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 Zan Dobersek 2017-06-09 01:00:32 PDT

Comment on attachment 312400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312400&action=review

> Source/WebKit2/ChangeLog:8
> +        We don't need to pass through WebKitWebViewBase, since the base doesn't an implementation.

You dropped a word there.

Comment 4 Carlos Garcia Campos 2017-06-10 23:28:13 PDT

Committed r218063: <http://trac.webkit.org/changeset/218063>