Summary: | RTCPeerConnection returns RTCSessionDescription where RTCSessionDescriptionInit would be appropriate | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Stefan Fochler <stefanf> | ||||||||||
Component: | Media | Assignee: | youenn fablet <youennf> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, eric.carlson, jonlee, rniwa, stefanf, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | Safari Technology Preview | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | macOS 10.12 | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=169816 | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 169644 | ||||||||||||
Attachments: |
|
Description
Stefan Fochler
2017-06-08 15:30:32 PDT
Created attachment 312823 [details]
Patch
Comment on attachment 312823 [details] Patch Attachment 312823 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3926085 New failing tests: imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-createOffer.html Created attachment 312835 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Comment on attachment 312823 [details] Patch Attachment 312823 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3926562 New failing tests: fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-createOffer.html Created attachment 312845 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 312874 [details]
Patch for landing
Thanks for the review. > New failing tests: > fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html > fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html The changes there show that we are no longer returning RTCSessionDescription. That said, we are still failing some assertions in these. Should be investigated further > imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-createOffer.html Going from FAIL to PASS :) Comment on attachment 312874 [details] Patch for landing Clearing flags on attachment: 312874 Committed r218335: <http://trac.webkit.org/changeset/218335> All reviewed patches have been landed. Closing bug. |