Bug 173113

Summary:

Update Timer to take a WTF::Function instead of a std::function

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, buildbot, ggaren, kling, koivisto

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

173125

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2017-06-08 14:42:17 PDT

Update Timer to take a WTF::Function instead of a std::function.

Attachments
Patch (2.88 KB, patch) 2017-06-08 14:43 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-06-08 14:43:30 PDT

Created attachment 312346 [details] Patch

Build Bot

Comment 2 2017-06-08 14:46:19 PDT

Attachment 312346 [details] did not pass style-queue: ERROR: Source/WebCore/platform/GenericTaskQueue.cpp:50: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/Timer.h:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/Timer.h:135: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/Timer.h:157: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/Timer.h:197: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 3 2017-06-08 16:05:10 PDT

Comment on attachment 312346 [details] Patch Clearing flags on attachment: 312346 Committed r217954: <http://trac.webkit.org/changeset/217954>

Chris Dumez

Comment 4 2017-06-08 16:05:12 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.