Bug 173106

Summary:

WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Tools / Tests

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bfulgham, buildbot, commit-queue, lforschler, rniwa, sam

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none

Darin Adler

Reported 2017-06-08 10:09:47 PDT

Many WTF tests hit stack-use-after-scope violation in ASan builds. <rdar://problem/32555205>

Attachments
Patch (27.30 KB, patch) 2017-06-08 10:11 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.44 MB, application/zip) 2017-06-08 10:51 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2017-06-08 10:11:46 PDT

Created attachment 312316 [details] Patch

Build Bot

Comment 2 2017-06-08 10:14:38 PDT

Attachment 312316 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:576: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:579: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2017-06-08 10:51:43 PDT

Comment on attachment 312316 [details] Patch Attachment 312316 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3894863 New failing tests: fast/mediastream/getUserMedia-grant-persistency.html

Build Bot

Comment 4 2017-06-08 10:51:44 PDT

Created attachment 312320 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Darin Adler

Comment 5 2017-06-08 11:04:12 PDT

Given what files this changes, no way the layout test failure has anything to do with this patch.

WebKit Commit Bot

Comment 6 2017-06-08 11:28:02 PDT

Comment on attachment 312316 [details] Patch Clearing flags on attachment: 312316 Committed r217938: <http://trac.webkit.org/changeset/217938>

WebKit Commit Bot

Comment 7 2017-06-08 11:28:04 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.