Summary: | Crash inside InsertNodeBeforeCommand via InsertParagraphSeparatorCommand | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | HTML Editing | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, enrica, sam, thorton, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2017-06-07 20:29:39 PDT
Created attachment 312270 [details]
Fixes the bug
Created attachment 312271 [details]
Updated the change log
Comment on attachment 312271 [details] Updated the change log View in context: https://bugs.webkit.org/attachment.cgi?id=312271&action=review > Source/WebCore/ChangeLog:5 > + Is there a radar link we can include? > Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:198 > + if (visiblePos.isNull()) Nit - Can we move this to right after we create visiblePos, so we don't have to calculateStyleBeforeInsertion() unnecessarily in the case that visiblePos.isNull()? (In reply to Wenson Hsieh from comment #4) > Comment on attachment 312271 [details] > Updated the change log > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312271&action=review > > > Source/WebCore/ChangeLog:5 > > + > > Is there a radar link we can include? Added. > > Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:198 > > + if (visiblePos.isNull()) > > Nit - Can we move this to right after we create visiblePos, so we don't have > to calculateStyleBeforeInsertion() unnecessarily in the case that > visiblePos.isNull()? Fixed. Committed r217958: <http://trac.webkit.org/changeset/217958> |