Bug 173040

Summary: Merge TreeScopeAdopter into TreeScope
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, kling, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup
none
Fixed builds
none
Fixed Windows build none

Ryosuke Niwa
Reported 2017-06-06 16:54:19 PDT
There is no need to have a separate class for this.
Attachments
Cleanup (50.88 KB, patch)
2017-06-06 17:04 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed builds (50.89 KB, patch)
2017-06-06 18:53 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed Windows build (52.11 KB, patch)
2017-06-06 20:04 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-06-06 17:04:59 PDT
Created attachment 312141 [details] Cleanup
Radar WebKit Bug Importer
Comment 2 2017-06-06 17:05:41 PDT
<rdar://problem/32602229>
Ryosuke Niwa
Comment 3 2017-06-06 18:53:11 PDT
Created attachment 312152 [details] Fixed builds
Ryosuke Niwa
Comment 4 2017-06-06 20:04:45 PDT
Created attachment 312157 [details] Fixed Windows build
Antti Koivisto
Comment 5 2017-06-07 00:10:57 PDT
Comment on attachment 312157 [details] Fixed Windows build This is so much more straightforward and understandable. TreeScopeAdopter was not a great factoring. r=me
Ryosuke Niwa
Comment 6 2017-06-07 00:34:16 PDT
Comment on attachment 312157 [details] Fixed Windows build Thanks for the review.
WebKit Commit Bot
Comment 7 2017-06-07 01:02:50 PDT
Comment on attachment 312157 [details] Fixed Windows build Clearing flags on attachment: 312157 Committed r217876: <http://trac.webkit.org/changeset/217876>
WebKit Commit Bot
Comment 8 2017-06-07 01:02:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.