Bug 173038

Summary: Refactoring: MediaEngineSupportParameters should take a ContentType rather than separate type & codecs strings
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Jer Noble
Reported 2017-06-06 15:34:06 PDT
Refactoring: MediaEngineSupportParameters should take a ContentType rather than separate type & codecs strings
Attachments
Patch (36.06 KB, patch)
2017-06-06 15:41 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (36.47 KB, patch)
2017-06-06 16:02 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (37.91 KB, patch)
2017-06-07 11:27 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (37.94 KB, patch)
2017-06-07 14:36 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-06-06 15:41:06 PDT
Created attachment 312131 [details] Patch
Jer Noble
Comment 2 2017-06-06 16:02:43 PDT
Created attachment 312133 [details] Patch
Jer Noble
Comment 3 2017-06-07 11:27:55 PDT
Created attachment 312204 [details] Patch
Eric Carlson
Comment 4 2017-06-07 13:28:37 PDT
Comment on attachment 312204 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312204&action=review > Source/WebCore/platform/ContentType.cpp:82 > String strippedType = m_type.stripWhiteSpace(); A little bird told me that we should use probably always stripWhite(isHTMLSpace). > Source/WebCore/platform/ContentType.cpp:92 > +static String simplifyWhitespace(const String& string) ...and that this was probably not necessary.
Jer Noble
Comment 5 2017-06-07 14:36:56 PDT
Created attachment 312231 [details] Patch for landing
WebKit Commit Bot
Comment 6 2017-06-07 15:15:54 PDT
Comment on attachment 312231 [details] Patch for landing Clearing flags on attachment: 312231 Committed r217905: <http://trac.webkit.org/changeset/217905>
WebKit Commit Bot
Comment 7 2017-06-07 15:15:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.